Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete builds #16430

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Remove obsolete builds #16430

merged 1 commit into from
Nov 9, 2022

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 9, 2022

The brave and opera builds are obsolete; in practice we have been using the Chrome build for those browsers, because they are based upon Chromium and are compatible with the Chrome extension API.

Manual Testing Steps

Make sure the build still works, I suppose?

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

The `brave` and `opera` builds are obsolete; in practice we have been
using the Chrome build for those browsers, because they are based upon
Chromium and are compatible with the Chrome extension API.
@Gudahtt Gudahtt marked this pull request as ready for review November 9, 2022 15:09
@Gudahtt Gudahtt requested review from a team and kumavis as code owners November 9, 2022 15:09
@Gudahtt Gudahtt requested a review from PeterYinusa November 9, 2022 15:09
@metamaskbot
Copy link
Collaborator

Builds ready [26b8f1f]
Page Load Metrics (2440 ± 371 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint911173227318152
domContentLoaded166448872414778373
load166448882440773371
domInteractive166348872414778373

@kumavis kumavis merged commit 6ff8044 into develop Nov 9, 2022
@kumavis kumavis deleted the remove-obsolete-builds branch November 9, 2022 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants