Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e remove redundant code #16432

Merged
merged 2 commits into from
Nov 9, 2022
Merged

E2e remove redundant code #16432

merged 2 commits into from
Nov 9, 2022

Conversation

PeterYinusa
Copy link
Contributor

@PeterYinusa PeterYinusa commented Nov 9, 2022

Explanation

  • Remove unused code in metamask-ui.spec.js, custom-token-add-approve.spec.js and send-eth.spec
  • Remove settings screen steps from send-eth.spec.js as they have no effect on the test

Screenshots/Screencaps

Before

n/a

After

n/a

Manual Testing Steps

The ci job ci/circleci: test-e2e-firefox and ci/circleci: test-e2e-chrome should be green

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@PeterYinusa PeterYinusa marked this pull request as ready for review November 9, 2022 15:33
@PeterYinusa PeterYinusa requested a review from a team as a code owner November 9, 2022 15:33
@metamaskbot
Copy link
Collaborator

Builds ready [5e51080]
Page Load Metrics (2449 ± 141 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint992878428778374
domContentLoaded187131792409279134
load187131792449294141
domInteractive187131792409279134

@PeterYinusa PeterYinusa merged commit 07b39de into develop Nov 9, 2022
@PeterYinusa PeterYinusa deleted the e2e-remove-redundant-code branch November 9, 2022 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants