Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: framework for overriding standard test validation methods #33

Merged
merged 23 commits into from
Jun 5, 2023
Merged

feat: framework for overriding standard test validation methods #33

merged 23 commits into from
Jun 5, 2023

Conversation

pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented Jun 2, 2023 •
edited
Loading

Related to #28

  • implements a sample target test class to make assertions on the table
  • assert row count, column count, and types
  • drop the table after the test is done

I disabled the python version matrix in CI because they were interfering with each other since right now we share a schema. Adding the github action run ID as a prefix on the schema is probably a good idea #34.

@pnadolny13 pnadolny13 changed the title framework for overriding standard test validation methods feat: framework for overriding standard test validation methods Jun 2, 2023
@pnadolny13 pnadolny13 mentioned this pull request Jun 2, 2023
Closed
Base automatically changed from ci_and_test_workflows to main June 5, 2023 17:11
@pnadolny13 pnadolny13 merged commit f144882 into main Jun 5, 2023
@pnadolny13 pnadolny13 deleted the test_validation branch June 5, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pnadolny13