Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests #28

Closed
4 tasks done
pnadolny13 opened this issue Jun 2, 2023 · 1 comment · Fixed by #38
Closed
4 tasks done

Add integration tests #28

pnadolny13 opened this issue Jun 2, 2023 · 1 comment · Fixed by #38
Assignees
@pnadolny13

Comments

@pnadolny13
Copy link
Contributor

pnadolny13 commented Jun 2, 2023 •
edited
Loading

target-postgres might be a helpful reference https://github.com/MeltanoLabs/target-postgres/blob/main/target_postgres/tests/test_standard_target.py

  • explore using the SDK target test framework
  • add test to create tables and assert theyre as expected
  • cleanup snowflake afterwards
  • test cases:
    • empty schema, create table from scratch
    • existing table, no schema updates
    • existing table, alter schema (add, remove, data type change)
    • duplicate row sent with and without key properties. if key properties it should be updated, without it should be inserted.
    • type mapping edge cases
    • handling reserved words in schema/table/column names
    • handling upper/lower case schema/table/column comparisons
    • lack of permissions handling
    • handling of file format of same name existing already. We cant really trust that the configs are correct so I think it needs to fail.
@pnadolny13 pnadolny13 mentioned this issue Jun 2, 2023
Closed
@pnadolny13 pnadolny13 self-assigned this Jun 5, 2023
@pnadolny13 pnadolny13 mentioned this issue Jun 5, 2023
Merged
@pnadolny13
Copy link
Contributor Author

In #28 we got the testing framework configured including cleanup afterwards.

Theres a bug, maybe in the SDK, thats blocking the tests from running properly so right now some pass even though they shouldnt.

@pnadolny13 pnadolny13 mentioned this issue Jun 6, 2023
Merged
pnadolny13 added a commit that referenced this issue Jun 6, 2023
@pnadolny13
fix: fix tests by overriding the runner for targets (#38)
bfd8814 
Closes #28

- implements a fix for the test suites not running properly, also added
it to the SDK meltano/sdk#1749
- implements a lot of the default test validates methods to make asserts
- comment out the tests that fail for legitimate bugs
- logged the bugs
  - #43
  - #41
  - #40
- I also logged
#42 because I
wrote a test to assert the exception but I'm not actually sure if we
want that behavior or not

---------

Co-authored-by: Ken Payne <[email protected]>
@github-project-automation github-project-automation bot moved this to Planned in Data Team Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnadolny13 pnadolny13

Labels
None yet
Projects
MeltanoLabs Overview
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix tests by overriding the runner for targets MeltanoLabs/target-snowflake
1 participant
@pnadolny13