bug: default test TargetSchemaUpdates fails column 'A3' already exists
#43
Assignees
Comments
pnadolny13
added a commit
that referenced
this issue
Jun 6, 2023
Closes #28 - implements a fix for the test suites not running properly, also added it to the SDK meltano/sdk#1749 - implements a lot of the default test validates methods to make asserts - comment out the tests that fail for legitimate bugs - logged the bugs - #43 - #41 - #40 - I also logged #42 because I wrote a test to assert the exception but I'm not actually sure if we want that behavior or not --------- Co-authored-by: Ken Payne <[email protected]>
pnadolny13
added a commit
that referenced
this issue
Jun 8, 2023
Closes #43 It turns out that this test had been fixed by other changes. I suspect it was part of #39. Previously I had implemented a way to cache table properties but I suspect that the cache was not being invalidated when the schema updated so it was attempting to recreate an existing column since it didnt find it in the cache.
github-project-automation
bot
moved this from In Progress
to Done
in MeltanoLabs Overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The test data https://github.com/meltano/sdk/blob/main/singer_sdk/testing/target_test_streams/schema_updates.singer tries to alter the schema of the table multiple times, each time adding a few records. The test is failing because it tries to add a column that already exists. I suspect its an upper/lower case issue related to comparing what exists.
The text was updated successfully, but these errors were encountered: