chore: uncomment SnowflakeTargetSchemaUpdates test #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pnadolny13 great! We have caching coming up-stream in the SDK, which is why I dropped it in the refactor 😅 |
kgpayne
approved these changes
Jun 8, 2023
|
@kgpayne I think the main bottle neck was in requesting column metadata for every column instead of caching it once for the table, I logged it in #29 though. I also wonder in meltano/sdk#1745 if it would be subject to the same bug I described here where schema changes within a single sync don't invalidate the cache 🤔 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43
It turns out that this test had been fixed by other changes. I suspect it was part of #39. Previously I had implemented a way to cache table properties but I suspect that the cache was not being invalidated when the schema updated so it was attempting to recreate an existing column since it didnt find it in the cache.