Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github action run id as a prefix on the schema name used in tests #34

Closed
pnadolny13 opened this issue Jun 2, 2023 · 1 comment
Closed

Add github action run id as a prefix on the schema name used in tests #34

pnadolny13 opened this issue Jun 2, 2023 · 1 comment

Comments

@pnadolny13
Copy link
Contributor

Context in #33 (comment)

I disabled the python version matrix in CI because they were interfering with each other since right now we share a schema. Adding the github action run ID as a prefix on the schema is probably a good idea.
@pnadolny13 pnadolny13 mentioned this issue Jun 2, 2023
Merged
pnadolny13 added a commit that referenced this issue Jun 5, 2023
@pnadolny13 @edgarrmondragon
feat: framework for overriding standard test validation methods (#33)
f144882 
- implements a sample target test class to make assertions on the table
- assert row count, column count, and types
- drop the table after the test is done

I disabled the python version matrix in CI because they were interfering
with each other since right now we share a schema. Adding the github
action run ID as a prefix on the schema is probably a good idea
#34.

---------

Co-authored-by: Edgar R. M. <[email protected]>
Co-authored-by: Ken Payne <[email protected]>
@pnadolny13
Copy link
Contributor Author

Closing because @kgpayne fixed this in #33 by adding a uuid to the schema name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pnadolny13