feat: Break out host, user, port, etc. into individual config values
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visch
changed the title
pnadolny13
reviewed
Jun 8, 2023
pnadolny13
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
@visch looks good to me! I made a small suggestion to add the secret attribute to the config.
edgarrmondragon
changed the title
host, user, port, etc. into individual config values
|
@visch Are you planning to implement the SSL option in this PR? |
Co-authored-by: Pat Nadolny <[email protected]>
No, I think we'll just add that, I updated the description for this PR. I'll get this merged. Thank you @pnadolny13 / @edgarrmondragon |
edgarrmondragon
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30, #5