Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SSL Connections #117

Closed
visch opened this issue Apr 30, 2023 · 0 comments · Fixed by #162
Closed

Support SSL Connections #117

visch opened this issue Apr 30, 2023 · 0 comments · Fixed by #162

Comments

@visch
Copy link
Member

visch commented Apr 30, 2023 •
edited
Loading

Technically this is already supported via https://docs.sqlalchemy.org/en/20/dialects/postgresql.html#ssl-connections

    "postgresql+psycopg2://scott:[email protected]:5432/test?sslmode=require"
)

But we will need to add explicit support for with #30
@visch visch mentioned this issue Jun 20, 2023
Merged
1 task
visch added a commit that referenced this issue Jun 23, 2023
@visch @edgarrmondragon @pnadolny13
feat: Break out host, user, port, etc. into individual config v…
4482e4e 
…alues (#121)

Closes #30, #5

- [x] Need to implement SSL as a configuration option as well (Going to
do separately see #117
)

---------

Co-authored-by: Edgar R. M <[email protected]>
Co-authored-by: Pat Nadolny <[email protected]>
@sebastianswms sebastianswms mentioned this issue Jul 5, 2023
Merged
visch added a commit that referenced this issue Jul 12, 2023
@sebastianswms @visch
feat: SSL (#162)
70ab988 
Implements SSL for postgres connections, as in
MeltanoLabs/target-postgres#131.

Closes #117

---------

Co-authored-by: Derek Visch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: SSL sebastianswms/tap-postgres
1 participant
@visch