-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break out host/port/username configurations #30
Comments
Dupe of #5, I think. I can push a PR for this if I get a ruling on whether we should
I don't care either way. Here's a repost of my comment on 5:
|
Hi, @qbatten. We ran into this elsewhere also. While the connector is still young, this is the right time to make a breaking change and remove support for arbitrary sqlalchemy_url inputs. Overrides or additions to the base string could optionally be exposed as "extra_sqlalchemy_args" config option. Driver-specific implementation choices should be abstracted away from the users, so that if we change the driver or certain implementation details without breaking (future) users. |
…alues (#121) Closes #30, #5 - [x] Need to implement SSL as a configuration option as well (Going to do separately see #117 ) --------- Co-authored-by: Edgar R. M <[email protected]> Co-authored-by: Pat Nadolny <[email protected]>
No description provided.
The text was updated successfully, but these errors were encountered: