Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytical overhaul #58

Merged
merged 60 commits into from
Jun 28, 2023
Merged

Analytical overhaul #58

merged 60 commits into from
Jun 28, 2023

Conversation

MaceKuailv
Copy link
Owner

This is going to replace PR #56. This PR is going to break down the lagrangian particle code in more logical way and test it.

Also solve some small issues.

@MaceKuailv MaceKuailv temporarily deployed to pypi June 20, 2023 01:51 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 96.24% and project coverage change: +1.76 🎉

Comparison is base (427b255) 92.81% compared to head (7bb3283) 94.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   92.81%   94.57%   +1.76%     
==========================================
  Files          11       11              
  Lines        2629     2638       +9     
  Branches      720      708      -12     
==========================================
+ Hits         2440     2495      +55     
+ Misses         85       53      -32     
+ Partials      104       90      -14     
Impacted Files Coverage Δ
seaduck/topology.py 88.13% <57.14%> (+0.84%) ⬆️
seaduck/utils.py 95.81% <91.66%> (+2.52%) ⬆️
seaduck/ocedata.py 96.65% <92.85%> (+4.98%) ⬆️
seaduck/lagrangian.py 95.38% <96.27%> (-0.33%) ⬇️
seaduck/smart_read.py 97.87% <97.82%> (+2.63%) ⬆️
seaduck/eulerian.py 94.81% <100.00%> (+0.85%) ⬆️
seaduck/get_masks.py 96.26% <100.00%> (+16.84%) ⬆️
seaduck/kernel_weight.py 95.16% <100.00%> (ø)
seaduck/oceinterp.py 98.64% <100.00%> (+4.53%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MaceKuailv MaceKuailv temporarily deployed to pypi June 20, 2023 02:19 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi June 25, 2023 21:20 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi June 27, 2023 16:46 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi June 27, 2023 21:06 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi June 27, 2023 22:31 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi June 27, 2023 23:01 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi June 28, 2023 14:35 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi June 28, 2023 14:54 — with GitHub Actions Inactive
@MaceKuailv
Copy link
Owner Author

This PR has been way too long. Although this has not yet accomplish what I hope to finish in this one PR, let's merge it and see if this PR would automatically resolve the issue that is really troubling me issue #55 .

That said, it had accomplished quite a lot.
#45 is resolved.
#17 is 85% resolved. Except for smart_read, every module has good coverage, and every test has with pytest.warns/raises or assert.
#50 is resolved. All weird aliases removed.
#22 is resolved. I made the decision to silence all runtime warnings. I know what they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant