Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break-up analytical function and test #56

Closed
wants to merge 4 commits into from
Closed

Break-up analytical function and test #56

wants to merge 4 commits into from

Conversation

MaceKuailv
Copy link
Owner

It is time to look at the trajectory really carefully.

Also some fixes to other small issues.

@MaceKuailv MaceKuailv temporarily deployed to pypi June 18, 2023 18:15 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Patch coverage: 84.09% and project coverage change: -0.31 ⚠️

Comparison is base (427b255) 92.81% compared to head (93723bc) 92.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   92.81%   92.50%   -0.31%     
==========================================
  Files          11       11              
  Lines        2629     2656      +27     
  Branches      720      726       +6     
==========================================
+ Hits         2440     2457      +17     
- Misses         85       92       +7     
- Partials      104      107       +3     
Impacted Files Coverage Δ
seaduck/lagrangian.py 93.52% <83.11%> (-2.18%) ⬇️
seaduck/oceinterp.py 93.24% <83.33%> (-0.88%) ⬇️
seaduck/eulerian.py 93.95% <100.00%> (ø)
seaduck/smart_read.py 95.23% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MaceKuailv
Copy link
Owner Author

Changed dask to dask[array] as discussed near the end of issue #49

@MaceKuailv MaceKuailv temporarily deployed to pypi June 18, 2023 18:59 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv temporarily deployed to pypi June 18, 2023 20:46 — with GitHub Actions Inactive
@MaceKuailv MaceKuailv mentioned this pull request Jun 20, 2023
@MaceKuailv
Copy link
Owner Author

Too many bug unnoticed when developing on this branch. Abandoned in favor of #58

@MaceKuailv MaceKuailv closed this Jun 20, 2023
@MaceKuailv MaceKuailv deleted the analytical branch June 22, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant