Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fp 1358 epic support ldap authentication #65

Merged

Conversation

jebesampaio
Copy link
Contributor

@jebesampaio jebesampaio commented Mar 8, 2022

https://movai.atlassian.net/browse/FP-1358

This is related to https://movai.atlassian.net/browse/FP-1293.
Most of the files affected are just because this branch was out of sync with dev. The relevant files are:

  • withAuthentication.js
  • LoginForm.js
  • LoginFormAdvanced.js
  • LoginForm/style.js

Tests
-npm ci before the tests to update lib-core package

  1. If no LDAP domains were created in the Configuration area, the login screen should not display the "Advanced" section, below the username and password fields
  2. If one or more domains were created in the new configuration area - check PR https://github.com/MOV-AI/frontend-npm-adminboard/pull/52 for more info, the Advanced section expand button should be displayed
  3. Clicking on the Advanced should display a selector with the the available domains plus "internal" should be available. Internal is the default for existing users such as movai.
  4. Because of lack of support from the backend, only login with internal user should work. trying to login with other domain selected should break the backend and require a restart.

… feature/fp-1357-epic-support-ldap-authentication
@jebesampaio jebesampaio changed the title Feature/fp 1357 epic support ldap authentication Feature/fp 1358 epic support ldap authentication Mar 10, 2022
@jebesampaio jebesampaio marked this pull request as ready for review March 11, 2022 16:59
@jebesampaio jebesampaio requested a review from a team as a code owner March 11, 2022 16:59
Copy link
Contributor

@RianMartins-Movai RianMartins-Movai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🎉

@jebesampaio jebesampaio marked this pull request as draft March 15, 2022 11:33
@jebesampaio jebesampaio marked this pull request as ready for review March 21, 2022 14:43
@jebesampaio jebesampaio merged commit 57abcba into develop/2.2.3 Mar 28, 2022
@jebesampaio jebesampaio deleted the feature/fp-1357-epic-support-ldap-authentication branch March 28, 2022 10:10
@jebesampaio jebesampaio restored the feature/fp-1357-epic-support-ldap-authentication branch March 30, 2022 14:21
This was referenced May 13, 2022
@diasdm diasdm deleted the feature/fp-1357-epic-support-ldap-authentication branch June 11, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants