Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give more flexibility to VerticalBar #66

Merged
merged 4 commits into from
Mar 11, 2022

Conversation

RianMartins-Movai
Copy link
Contributor

Small adjustments to give more flexibility to VerticalBar

@RianMartins-Movai RianMartins-Movai added the enhancement New feature or request label Mar 10, 2022
@RianMartins-Movai RianMartins-Movai requested a review from a team March 10, 2022 17:39
@RianMartins-Movai RianMartins-Movai self-assigned this Mar 10, 2022
Copy link
Contributor

@jebesampaio jebesampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Adminboard and working 👍

src/Components/VerticalBar.js Outdated Show resolved Hide resolved
src/Components/VerticalBar.js Outdated Show resolved Hide resolved
src/Components/VerticalBar.js Outdated Show resolved Hide resolved
.storybook/middleware.js Outdated Show resolved Hide resolved
jebesampaio
jebesampaio previously approved these changes Mar 11, 2022
Copy link
Contributor

@jebesampaio jebesampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🍾

.storybook/middleware.js Show resolved Hide resolved
@jebesampaio
Copy link
Contributor

Re-tested after changes and working

Copy link
Contributor

@manuelnogueiramov manuelnogueiramov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉

@jebesampaio jebesampaio merged commit fa4fa8b into dev Mar 11, 2022
@jebesampaio jebesampaio deleted the feature/FP-1589-adjustments-in-vertical-bar branch March 11, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants