Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fp 1293 ldap configuration page - fix click on profile menu not working #64

Merged
merged 6 commits into from
Mar 10, 2022

Conversation

jebesampaio
Copy link
Contributor

@jebesampaio jebesampaio commented Mar 8, 2022

https://movai.atlassian.net/browse/FP-1293

This PR addresses 4 issues found during the development of FP-1293:

  1. Click not working on an extra item in profile menu. To test, use the ProfileMenu component from lib-react and then add an extra item configuration. Click the extra item and the corresponding function should be called
  2. The lib Select component was not handling the scenario where it would receive the multiple prop
  3. The material table component was not receiving all props
  4. Storybook returning an error when starting - npm run storybook

@jebesampaio jebesampaio requested a review from a team as a code owner March 8, 2022 18:16
Copy link
Contributor

@RianMartins-Movai RianMartins-Movai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job 🎉

@RianMartins-Movai RianMartins-Movai requested a review from a team March 10, 2022 17:44
@RianMartins-Movai RianMartins-Movai merged commit dacd042 into dev Mar 10, 2022
@RianMartins-Movai RianMartins-Movai deleted the feature/FP-1293-LDAP-configuration-page branch March 10, 2022 17:58
@jebesampaio jebesampaio restored the feature/FP-1293-LDAP-configuration-page branch March 11, 2022 09:54
@diasdm diasdm deleted the feature/FP-1293-LDAP-configuration-page branch June 11, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants