Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version caps #448

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Remove version caps #448

merged 2 commits into from
Apr 20, 2023

Conversation

cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Apr 14, 2023

Currently, all versions are capped, because the caret ^ operator also introduces an upper bound. In this PR, I replaced ^ with >=, which continues to use the same lower bounds, but removes any upper bound.

@cbrnr cbrnr mentioned this pull request Apr 14, 2023
@tompollard
Copy link
Member

Thanks @cbrnr, please could you rebase? Not immediately clear why the tests are failing. Looks like they are failing on a style issue in a chunk of unrelated code?

@cbrnr
Copy link
Contributor Author

cbrnr commented Apr 14, 2023

Done. It's because the previous pandas-related change interferred with these modifications.

@tompollard
Copy link
Member

@bemoody Please could you add your thoughts on this PR? I see that SoundFile is explicitly pinning an upper bound (SoundFile = ">=0.10.0, <0.12.0"), which I assume is intentional? Does this need to stay?

@cbrnr Presumably the change to Black is causing the tests to fail. We need to look into what's happening there!

@cbrnr
Copy link
Contributor Author

cbrnr commented Apr 14, 2023

I've fixed all Black issues, these were related to empty lines that shouldn't be there. Seems like they updated their style guide, because I noticed the same in one of my projects recently.

Let me know about the SoundFile version. If you really need to keep <0.12.0, we should add a test.

Copy link
Member

@tompollard tompollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cbrnr, looks good to me! @bemoody?

@tompollard
Copy link
Member

@bemoody is happy

@tompollard tompollard merged commit 4fd577f into MIT-LCP:main Apr 20, 2023
@cbrnr cbrnr deleted the remove-version-caps branch October 14, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants