-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Pandas 2.0? #446
Comments
I ran the tests with pandas 2.0.0 and they all pass. Please let me know if you would like me to submit a PR. FWIW, capping dependencies are usually not ideal, so if possible please consider removing all upper bounds from your dependencies (see e.g. https://iscinumpy.dev/post/bound-version-constraints/#tldr for an explanation). |
Thanks for looking at this @cbrnr.
Yes, please, I'd appreciate it. Thanks!
I hadn't realised that the @bemoody any reasons why we shouldn't remove all of the upper bounds in pyproject.toml as suggested? Seems like a good idea to me. @cbrnr if you have time, please also feel free to open a (separate) PR for this. |
Great! @tompollard Any chance of tagging a new release with this change? |
@hoechenberger sure, we'll do this shortly. @bemoody has been managing the updates recently. Benjamin, okay with making a new release? Let me know if you'd like me to take care of it. It would be good if we could merge #448 beforehand too. |
@hoechenberger Done! See: https://pypi.org/project/wfdb/4.1.1/
|
Thank you! |
Hello, currently, Pandas is pinned to version 1.x:
wfdb-python/pyproject.toml
Line 16 in 4d4233f
Meanwhile, Pandas 2.0 has been released, and trying to install it alongside
wfdb
logically leads to a dependency conflict.I wanted to ask if
wfdb
is supposed to not work with Pandas 2.0 now or if the version pinning is unnecessarily restrictive and could be relaxed to include Pandas 2.0 as well?Thanks,
Richard
The text was updated successfully, but these errors were encountered: