Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Pandas 2.0? #446

Closed
hoechenberger opened this issue Apr 13, 2023 · 7 comments · Fixed by #447
Closed

Support for Pandas 2.0? #446

hoechenberger opened this issue Apr 13, 2023 · 7 comments · Fixed by #447

Comments

@hoechenberger
Copy link

Hello, currently, Pandas is pinned to version 1.x:

pandas = "^1.0.0"

Meanwhile, Pandas 2.0 has been released, and trying to install it alongside wfdb logically leads to a dependency conflict.

I wanted to ask if wfdb is supposed to not work with Pandas 2.0 now or if the version pinning is unnecessarily restrictive and could be relaxed to include Pandas 2.0 as well?

Thanks,
Richard

@cbrnr
Copy link
Contributor

cbrnr commented Apr 14, 2023

I ran the tests with pandas 2.0.0 and they all pass. Please let me know if you would like me to submit a PR.

FWIW, capping dependencies are usually not ideal, so if possible please consider removing all upper bounds from your dependencies (see e.g. https://iscinumpy.dev/post/bound-version-constraints/#tldr for an explanation).

@tompollard
Copy link
Member

Thanks for looking at this @cbrnr.

Please let me know if you would like me to submit a PR.

Yes, please, I'd appreciate it. Thanks!

FWIW, capping dependencies are usually not ideal, so if possible please consider removing all upper bounds from your dependencies (see e.g. https://iscinumpy.dev/post/bound-version-constraints/#tldr for an explanation).

I hadn't realised that the ^ was adding an upper bound, but I now see that it is. I don't think there's any reason why we want to be fixing ourselves on these old versions (certainly not for pandas, at least).

@bemoody any reasons why we shouldn't remove all of the upper bounds in pyproject.toml as suggested? Seems like a good idea to me. @cbrnr if you have time, please also feel free to open a (separate) PR for this.

@cbrnr
Copy link
Contributor

cbrnr commented Apr 14, 2023

Great! See #447 and #448.

@hoechenberger
Copy link
Author

Great! @tompollard Any chance of tagging a new release with this change?

@tompollard
Copy link
Member

@hoechenberger sure, we'll do this shortly. @bemoody has been managing the updates recently. Benjamin, okay with making a new release? Let me know if you'd like me to take care of it. It would be good if we could merge #448 beforehand too.

@tompollard
Copy link
Member

@hoechenberger Done! See: https://pypi.org/project/wfdb/4.1.1/

pip install wfdb --upgrade should bump you to the latest version.

@hoechenberger
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants