Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bounds on dependencies #1977

Open
tompollard opened this issue Apr 24, 2023 · 0 comments
Open

Remove upper bounds on dependencies #1977

tompollard opened this issue Apr 24, 2023 · 0 comments

Comments

@tompollard
Copy link
Member

tompollard commented Apr 24, 2023

As discussed in MIT-LCP/wfdb-python#446 and https://iscinumpy.dev/post/bound-version-constraints/#tldr, setting upper bounds on dependencies is perhaps not a good idea.

Currently most dependencies in https://github.com/MIT-LCP/physionet-build/blob/dev/pyproject.toml are specified with PACKAGE = "^n.n.n". The carat sets an upper bound on the major version.

We should consider switching these to PACKAGE = ">n.n.n", as we did in MIT-LCP/wfdb-python#448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant