Make Travis run tests on OSX. #771
Conversation
Signed-off-by: Zhenbo Li <[email protected]>
|
Hey, thanks for taking this on. The travis check isn't showing up though? |
|
Thank you for reviewing my patch. I'm wondering why this PR hasn't be shown in https://travis-ci.org/MDAnalysis/mdanalysis/pull_requests. Despite of it, I've tested my patch on Travis: https://travis-ci.org/Endle/mdanalysis/builds/116079307 |
| @@ -4,7 +4,9 @@ branches: | |||
| - master | |||
| - develop | |||
|
|
|||
| language: python | |||
There was a problem hiding this comment.
maybe this line is needed?
There was a problem hiding this comment.
Python + OSX will break Travis CI.
As we use miniconda, it's fine to skip the language.
Maybe the reason is that I have tested this patch with my repo?
|
does travis support multi OS testing by default now? I thought that they require us to sign up for that separately. |
|
Iirc osx is supported, but not Python on osx. But conda works around that On Wed, 16 Mar 2016 09:59 kain88-de, [email protected] wrote:
|
now it started all 8 defined jobs for this PR |
Make Travis run tests on OSX.
|
Cool, thanks @Endle ! |
Update of AUTHORS and CHANGELOG with inferred author contributions.
* Removed duplicate mattwthompson in 0.20.0 changelog entry.: mattwthompson was placed twice by accident, this removes this duplication.
* Addition of missing authors.
An retrospective analysis of the authors found via `git shortlog -s -n --email --branches="develop"` found several commits by authors which were not present in the `AUTHORS.md` file.
- Zhenbo Li: commited via PR: Started tests for gnm. #803 and Make Travis run tests on OSX. #771,
- Jenna M. Swarthout via PR Update CoC according to suggestions from current CoC committee #4289 and Point to new reporting form link (owned by [email protected]) #4298,
- Bradley Dice via PR Fix GSD Windows compatibility #2384 ,
- David Minh via PR #2668
There seemed to be no indications in the above mentioned PRs that the author did not want to be in the authors file, it looks like it was just forgotten.
* Addition of missing entries from the changelog
Continued cross referencing of the git shortlog output but also accounting for the changelog identified several individuals that had not been included in the changelog entries for the release they contributed under. They were added to the relevant entry of the changelog based on the merge commit date.
Please note that for Tone Bengsten, we a) had no github handle (so they were assigned @tbengtsen), and b) no specific commit. Given we know that this individual was including alongside the encore merge, they were assigned to the 0.16.0 release.
* Update CHANGELOG
* PR #1218
* PR #1284 and #1408
* PR #4109
* based on git history
* PRs #803 and #771 (author addition, changelog addition)
* PR #2255 and #2221
* PR #1225
* PR #4289 and #4298
* PR #4031
* PR #4085
* PR #3635
* PR #2356
* PR #2559
* No GH handle - Encore author addition @tbengtsen
* PR #4184
* PR #2614
* PR #2219
* PR #2384
* PR #2668
* Add missing entry for Jenna
Thanks to @fiona-naughton for helping out with digging into this data :)
Co-authored-by: Fiona Naughton <[email protected]>
Co-authored-by: Oliver Beckstein <[email protected]>
Fixes #368
Changes made in this Pull Request:
PR Checklist
Signed-off-by: Zhenbo Li [email protected]