Update CoC according to suggestions from current CoC committee #4289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CoC Committee voted on Sep 1, 2023 to remove the mailing list option. See notes from the meeting leading to this recommendation here: https://docs.google.com/document/d/1TyTOm7Z-769l8BV0v1oncBBETVEqiiQayHqk3dNg7yo/edit?usp=sharing
Instead of including names of CoC Committee members here, it would be best to move names to the Roles & Responsibilities page when it is up (MDAnalysis#300) and provide a link
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on the developer mailing list so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
Linter Bot Results:Hi @jennaswa! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
|
In addition, we propose to set up a [email protected] account, which would be used to change ownership of the reporting form. There are also a few proposed changes to the questions on the reporting form itself to assist with collecting details relevant to an incident. See our google doc on CoCC & Procedures for notes on all proposed changes. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4289 +/- ##
==========================================
Coverage 93.40% 93.40%
==========================================
Files 170 184 +14
Lines 22255 23364 +1109
Branches 4071 4071
==========================================
+ Hits 20788 21824 +1036
- Misses 951 1024 +73
Partials 516 516 ☔ View full report in Codecov by Sentry. |
richardjgowers
approved these changes
Sep 17, 2023
RMeli
approved these changes
Sep 17, 2023
orbeckst
approved these changes
Sep 17, 2023
orbeckst
requested review from
fiona-naughton,
IAlibay,
hmacdope,
micaela-matta and
lilyminium
IAlibay
approved these changes
Sep 17, 2023
Co-authored-by: Oliver Beckstein <[email protected]>
orbeckst
added a commit
that referenced
this pull request
Dec 21, 2023
Update of AUTHORS and CHANGELOG with inferred author contributions.
* Removed duplicate mattwthompson in 0.20.0 changelog entry.: mattwthompson was placed twice by accident, this removes this duplication.
* Addition of missing authors.
An retrospective analysis of the authors found via `git shortlog -s -n --email --branches="develop"` found several commits by authors which were not present in the `AUTHORS.md` file.
- Zhenbo Li: commited via PR: Started tests for gnm. #803 and Make Travis run tests on OSX. #771,
- Jenna M. Swarthout via PR Update CoC according to suggestions from current CoC committee #4289 and Point to new reporting form link (owned by [email protected]) #4298,
- Bradley Dice via PR Fix GSD Windows compatibility #2384 ,
- David Minh via PR #2668
There seemed to be no indications in the above mentioned PRs that the author did not want to be in the authors file, it looks like it was just forgotten.
* Addition of missing entries from the changelog
Continued cross referencing of the git shortlog output but also accounting for the changelog identified several individuals that had not been included in the changelog entries for the release they contributed under. They were added to the relevant entry of the changelog based on the merge commit date.
Please note that for Tone Bengsten, we a) had no github handle (so they were assigned @tbengtsen), and b) no specific commit. Given we know that this individual was including alongside the encore merge, they were assigned to the 0.16.0 release.
* Update CHANGELOG
* PR #1218
* PR #1284 and #1408
* PR #4109
* based on git history
* PRs #803 and #771 (author addition, changelog addition)
* PR #2255 and #2221
* PR #1225
* PR #4289 and #4298
* PR #4031
* PR #4085
* PR #3635
* PR #2356
* PR #2559
* No GH handle - Encore author addition @tbengtsen
* PR #4184
* PR #2614
* PR #2219
* PR #2384
* PR #2668
* Add missing entry for Jenna
Thanks to @fiona-naughton for helping out with digging into this data :)
Co-authored-by: Fiona Naughton <[email protected]>
Co-authored-by: Oliver Beckstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CoC committee (@jennaswa, @micaela-matta, and @richardjgowers) met on September 1, 2023 to discuss proposed updates to the MDAnalysis CoC and CoC procedures. This PR reflects the proposed changes agreed upon by the committee and requires approval from all core developers.
Changes made in this Pull Request:
-Remove option to file a report by e-mail
-Edit language throughout to clarify that CoC Committee is responsible for receiving, investigating, and enforcing reports
-Add reporting procedures for events (and acknowledge NumFOCUS for this text)
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4289.org.readthedocs.build/en/4289/