Opting in ci-helpers for travis testing #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnmelo
reviewed
Apr 5, 2017
.travis.yml
Outdated
| test ${TRAVIS_BRANCH} == ${GH_DOC_BRANCH} && \ | ||
| test "${BUILD_DOCS}" == "true"; then | ||
| bash ${TRAVIS_BUILD_DIR}/maintainer/deploy_docs.sh | ||
| if |
There was a problem hiding this comment.
Hmm, I've fixed that already a couple of hours ago, but apparently pushed to the wrong branch...
bsipocz
force-pushed
the
opt_in_ci_helpers
branch
from
6876f7c to
6cab7c4
Compare
|
Hmmm... the travis builds weren't triggered? |
|
@mnmelo - They have some issues with their database, maybe that's causing this, too. This is the run on my fork with the same commit: https://travis-ci.org/bsipocz/mdanalysis/builds/218986875 |
|
(closing and reopening to try to trigger travis) |
|
Yup, that did it. |
|
@kain88-de, could you please have a look and approve? This is much more your thing... |
kain88-de
approved these changes
Apr 6, 2017
|
@bsipocz Thanks for the help |
|
Thanks for yours, too, @kain88-de. |
orbeckst
added a commit
that referenced
this pull request
Dec 21, 2023
Update of AUTHORS and CHANGELOG with inferred author contributions.
* Removed duplicate mattwthompson in 0.20.0 changelog entry.: mattwthompson was placed twice by accident, this removes this duplication.
* Addition of missing authors.
An retrospective analysis of the authors found via `git shortlog -s -n --email --branches="develop"` found several commits by authors which were not present in the `AUTHORS.md` file.
- Zhenbo Li: commited via PR: Started tests for gnm. #803 and Make Travis run tests on OSX. #771,
- Jenna M. Swarthout via PR Update CoC according to suggestions from current CoC committee #4289 and Point to new reporting form link (owned by [email protected]) #4298,
- Bradley Dice via PR Fix GSD Windows compatibility #2384 ,
- David Minh via PR #2668
There seemed to be no indications in the above mentioned PRs that the author did not want to be in the authors file, it looks like it was just forgotten.
* Addition of missing entries from the changelog
Continued cross referencing of the git shortlog output but also accounting for the changelog identified several individuals that had not been included in the changelog entries for the release they contributed under. They were added to the relevant entry of the changelog based on the merge commit date.
Please note that for Tone Bengsten, we a) had no github handle (so they were assigned @tbengtsen), and b) no specific commit. Given we know that this individual was including alongside the encore merge, they were assigned to the 0.16.0 release.
* Update CHANGELOG
* PR #1218
* PR #1284 and #1408
* PR #4109
* based on git history
* PRs #803 and #771 (author addition, changelog addition)
* PR #2255 and #2221
* PR #1225
* PR #4289 and #4298
* PR #4031
* PR #4085
* PR #3635
* PR #2356
* PR #2559
* No GH handle - Encore author addition @tbengtsen
* PR #4184
* PR #2614
* PR #2219
* PR #2384
* PR #2668
* Add missing entry for Jenna
Thanks to @fiona-naughton for helping out with digging into this data :)
Co-authored-by: Fiona Naughton <[email protected]>
Co-authored-by: Oliver Beckstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets green lights when testing on my fork, I'm not totally sure why the last statement didn't cause problems before ci-helpers.
Also there may be some other parts where ci-helpers could be used, but overall it won't be much simpler (e.g. we usually cut our test cmd into two part, MAIN_CMD and SETUP_CMD, and when the latter starts with
build_sphinx, it will recognize it and installs sphinx).Also I can add pylint to the list of linters we support.