-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reverting optional task for v0.11 [wip] #1856
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
added
help wanted
Extra attention is needed
Important
milestonish
refactoring
refactoring and code health
API / design
labels
Jun 23, 2023
Borda
force-pushed
the
revert/required-task
branch
from
June 23, 2023 22:47
2232582
to
78151cc
Compare
Borda
force-pushed
the
revert/required-task
branch
from
June 23, 2023 22:51
7786c03
to
34f9046
Compare
for more information, see https://pre-commit.ci
Borda
changed the title
reverting optional task for v0.11
reverting optional task for v0.11 [wip]
Jul 3, 2023
Borda
requested review from
SkafteNicki,
justusschock,
tchaton,
edenlightning and
ethanwharris
as code owners
July 3, 2023 11:51
Borda
force-pushed
the
revert/required-task
branch
from
July 3, 2023 12:48
39f085f
to
9f714e4
Compare
for more information, see https://pre-commit.ci
@Borda I would vote for us closing this PR and corresponding issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API / design
help wanted
Extra attention is needed
Important
milestonish
refactoring
refactoring and code health
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1670
Partial revert of #1252 for module-like metrics (not functional)
Facilitate/smooth compatibility before v1.0
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃