Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace local adjustment script with external #1758

Merged
merged 8 commits into from
May 9, 2023
Merged

replace local adjustment script with external #1758

merged 8 commits into from
May 9, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented May 5, 2023

What does this PR do?

let's keep these updates at one place: Lightning-AI/utilities#132

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda enabled auto-merge (squash) May 5, 2023 18:32
@Borda Borda requested review from lantiga, stancld and a team May 5, 2023 18:42
@Borda
Copy link
Member Author

Borda commented May 5, 2023

The failing docs seem strange and unrelated... ref: readthedocs/readthedocs.org#10290

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #1758 (412e8e1) into master (37c75d3) will increase coverage by 0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1758   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         250     250           
  Lines       14012   14012           
======================================
+ Hits        12243   12255   +12     
+ Misses       1769    1757   -12     

@mergify mergify bot added the ready label May 5, 2023
@Borda Borda disabled auto-merge May 9, 2023 09:34
@Borda Borda merged commit 0bf4dc0 into master May 9, 2023
@Borda Borda deleted the adjust-torch branch May 9, 2023 09:35
Borda added a commit that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants