-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace local adjustment script with external #1758
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
ethanwharris,
SkafteNicki and
justusschock
as code owners
May 5, 2023 18:17
stancld
approved these changes
May 5, 2023
The failing docs seem strange and unrelated... ref: readthedocs/readthedocs.org#10290 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1758 +/- ##
======================================
Coverage 87% 87%
======================================
Files 250 250
Lines 14012 14012
======================================
+ Hits 12243 12255 +12
+ Misses 1769 1757 -12 |
justusschock
approved these changes
May 9, 2023
Borda
added a commit
that referenced
this pull request
Jul 3, 2023
(cherry picked from commit 0bf4dc0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
let's keep these updates at one place: Lightning-AI/utilities#132
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃