Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hold required task=... for 1.0 #1670

Closed
Borda opened this issue Mar 31, 2023 · 0 comments
Closed

hold required task=... for 1.0 #1670

Borda opened this issue Mar 31, 2023 · 0 comments
Labels
enhancement New feature or request Important milestonish refactoring refactoring and code health

Comments

@Borda
Copy link
Member

Borda commented Mar 31, 2023

🚀 Feature

Classification metrics become task specific since 0.10, meaning use shall import <Task><Metric> or set a task in Metric(task=<task>) which resolved much confusion of automatic task estimation. Also, the 0.10 set this task as optional, so it still supports leaving the decision to TM. In 0.11, we have set this task argument as required, which would break many naive users' use cases and prevent them from upgrading to the latest

Motivation

Just thinking as we made this breaking change in 0.11 with the making task required, and the next will be 1.0, so to re-release all from the 0.11 series with post (so, for example, 0.11.2.post1)

so all will be rereleased

  • 0.11.0.post1
  • 0.11.1.post1
  • 0.11.2.post1
  • 0.11.3.post1
  • 0.11.4.post1

Pitch

When we allow not passing task and hold this friction for 1.0 so, it will also be easier to communicate and for a user to decide if he stays below 1.0 or after...

Alternatives

Additional context

@Borda Borda added enhancement New feature or request refactoring refactoring and code health labels Mar 31, 2023
@Borda Borda added the Important milestonish label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Important milestonish refactoring refactoring and code health
Projects
None yet
Development

No branches or pull requests

3 participants
@Borda @SkafteNicki and others