-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkpoint migration for loop's internal state #15500
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…ature/migration-utils
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ature/migration-utils
awaelchli
added
refactor
checkpointing
Related to checkpointing
and removed
pl
Generic label for PyTorch Lightning package
labels
Nov 3, 2022
for more information, see https://pre-commit.ci
awaelchli
changed the title
Checkpoint migration for loop's global step
Checkpoint migration for loop's global step and epoch
Nov 3, 2022
…o feature/migration-functions
awaelchli
changed the title
Checkpoint migration for loop's global step and epoch
Checkpoint migration for loop's internal state
Nov 3, 2022
awaelchli
requested review from
carmocca,
rohitgr7,
otaj,
justusschock and
Borda
as code owners
November 3, 2022 13:59
awaelchli
commented
Nov 3, 2022
11 tasks
awaelchli
requested review from
williamFalcon,
tchaton and
kaushikb11
as code owners
November 4, 2022 17:10
otaj
approved these changes
Nov 7, 2022
carmocca
approved these changes
Nov 8, 2022
justusschock
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
checkpointing
Related to checkpointing
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The migration tools introduced in #15237 allow us to get rid of some code in the loops and checkpoint connector, as we can directly define migrations that apply the necessary changes to the checkpoint dict.
This also has the benefit that the checkpoint can be permanently upgraded (see #15333)
Part of #9396
Relevant old PRs:
global_step
while restoring logging step for old checkpoints #13645Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @justusschock @awaelchli @rohitgr7 @ananthsub @ninginthecloud @otaj