Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint migration for loop's internal state #15500

Merged
merged 34 commits into from
Nov 8, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 3, 2022

What does this PR do?

The migration tools introduced in #15237 allow us to get rid of some code in the loops and checkpoint connector, as we can directly define migrations that apply the necessary changes to the checkpoint dict.

This also has the benefit that the checkpoint can be permanently upgraded (see #15333)

Part of #9396

Relevant old PRs:

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @ananthsub @ninginthecloud @otaj

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 3, 2022
@awaelchli awaelchli added refactor checkpointing Related to checkpointing and removed pl Generic label for PyTorch Lightning package labels Nov 3, 2022
@awaelchli awaelchli self-assigned this Nov 3, 2022
@awaelchli awaelchli changed the title Checkpoint migration for loop's global step Checkpoint migration for loop's global step and epoch Nov 3, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 3, 2022
@awaelchli awaelchli changed the title Checkpoint migration for loop's global step and epoch Checkpoint migration for loop's internal state Nov 3, 2022
@awaelchli awaelchli marked this pull request as ready for review November 3, 2022 13:59
@awaelchli awaelchli added this to the v1.9 milestone Nov 3, 2022
@awaelchli awaelchli mentioned this pull request Nov 4, 2022
11 tasks
@mergify mergify bot added the has conflicts label Nov 4, 2022
@mergify mergify bot removed the has conflicts label Nov 5, 2022
@mergify mergify bot added the ready PRs ready to be merged label Nov 8, 2022
@awaelchli awaelchli enabled auto-merge (squash) November 8, 2022 15:25
@awaelchli awaelchli merged commit bc2cf45 into master Nov 8, 2022
@awaelchli awaelchli deleted the feature/migration-functions branch November 8, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants