Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global_step while restoring logging step for old checkpoints #13645

Merged
merged 13 commits into from
Jul 19, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jul 13, 2022

What does this PR do?

Here #13467, we fixed the issue by restoring the logging step from the checkpoint, but for the cases where old checkpoints (<v1.6.5) are used, the behavior will still be the same because that key will not be present in old checkpoints and logging will start from 0. To avoid this, the default behavior is changed to restore global_step instead.

Discussed with @carmocca

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy

@rohitgr7 rohitgr7 added bug Something isn't working logging Related to the `LoggerConnector` and `log()` labels Jul 13, 2022
@rohitgr7 rohitgr7 added this to the pl:1.7 milestone Jul 13, 2022
@rohitgr7 rohitgr7 self-assigned this Jul 13, 2022
tests/tests_pytorch/models/test_restore.py Outdated Show resolved Hide resolved
tests/tests_pytorch/models/test_restore.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !

@mergify mergify bot added the ready PRs ready to be merged label Jul 14, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/tests_pytorch/models/test_restore.py Show resolved Hide resolved
@rohitgr7 rohitgr7 enabled auto-merge (squash) July 14, 2022 11:55
@rohitgr7 rohitgr7 marked this pull request as draft July 14, 2022 18:34
auto-merge was automatically disabled July 14, 2022 18:34

Pull request was converted to draft

@rohitgr7 rohitgr7 marked this pull request as ready for review July 14, 2022 18:54
@rohitgr7 rohitgr7 requested review from awaelchli and carmocca July 14, 2022 18:55
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 15, 2022
@rohitgr7 rohitgr7 requested a review from carmocca July 15, 2022 14:44
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 16, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) July 16, 2022 21:22
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #13645 (0c73b63) into master (2845e75) will decrease coverage by 10%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13645     +/-   ##
=========================================
- Coverage      86%      76%    -10%     
=========================================
  Files         326      327      +1     
  Lines       25394    25512    +118     
=========================================
- Hits        21839    19446   -2393     
- Misses       3555     6066   +2511     

@rohitgr7 rohitgr7 merged commit c67b075 into master Jul 19, 2022
@rohitgr7 rohitgr7 deleted the fix/restore_step branch July 19, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants