Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the checkpoint upgrade utility script #15333

Merged
merged 23 commits into from
Nov 4, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 26, 2022

What does this PR do?

This PR improves the special cmdline script for upgrading checkpoints:

  • Now accepts a directory and can support search
  • Error messaging when file(s) are not found
  • No longer overwrites existing backup files if the running the command twice. Losing a checkpoint like this could be detrimental.
  • Now has a progress bar
  • Also adds missing docs

Part of #9396

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @awaelchli @ananthsub @ninginthecloud @rohitgr7 @otaj

@awaelchli awaelchli added feature Is an improvement or enhancement checkpointing Related to checkpointing labels Oct 26, 2022
@awaelchli awaelchli self-assigned this Oct 26, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 26, 2022
@awaelchli awaelchli added this to the v1.9 milestone Oct 26, 2022
@awaelchli awaelchli mentioned this pull request Oct 28, 2022
11 tasks
@awaelchli awaelchli marked this pull request as ready for review November 2, 2022 18:16
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat !

@mergify mergify bot added the ready PRs ready to be merged label Nov 4, 2022
@awaelchli awaelchli enabled auto-merge (squash) November 4, 2022 20:29
@awaelchli awaelchli merged commit dcfaa06 into master Nov 4, 2022
@awaelchli awaelchli deleted the feature/upgrade-checkpoint branch November 4, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants