-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Login using twinkletoes server #3
Comments
Social logins via both Facebook and Google are enabled in config/config.dist.php which is copied to create config/config.php, so perhaps worth disabling by default? $conf['settings']['authentication']['allow.facebook.login'] = 'false'; |
…sing twinkletoes server for this functionality Disabled facebook and google login by default, as these options are using twinkletoes server for this functionality, issue #3
Agreed, should have done it sooner, thanks for letting me know. |
I might be able to help with this as I have a use case that could highly benefit from social login. I've done social auth for my full time job so maybe assign a new social auth feature ticket to me. The best way to handle that, without going in to much detail here, is to have companies setup their own social authentication with their own branding and configure that within Bookedscheduler. This might just be a documentation task...? |
Any help with this issue is welcome, I personally don't have much experience with social authentication, so I'm usually a bit weary of messing it up. In the mean time, thanks to the help of a work colleague, there's a working solution for the google part of the social login (https://github.com/effgarces/Booked_GoogleLogin) I already started integrating it, but my chronic lack of time (too much work, projects, etc...) is working against me. |
Thanks, the o365 login might be something I can use going forward, I'll have to check it out when I get time to mess around. Not that it matters, but I loathe FB too, google not much better lately. I don't enable any social log ins on my old 2.6.6, but maybe going forward the o365 might be nice since we are an o365 facility. |
Past Reservations display on dashboard
Got the following error: Slim Application Error The application could not run because of the following error: Details Code: 8192 Message:urlencode(): Passing null to parameter #1 ($string) of type string is deprecated File:/var/www/html/lib/Server/Url.php Line: 52 Trace: #0 [internal function]: Slim\Slim::handleErrors() #1 /var/www/html/lib/Server/Url.php(52): urlencode() #2 /var/www/html/lib/Application/Schedule/CalendarSubscriptionUrl.php(26): Url->AddQueryString() LibreBooking#3 /var/www/html/WebServices/Responses/ResourceResponse.php(82): CalendarSubscriptionUrl->__construct() LibreBooking#4 /var/www/html/WebServices/Responses/ResourcesResponse.php(20): ResourceResponse->__construct() LibreBooking#5 /var/www/html/WebServices/ResourcesWebService.php(65): ResourcesResponse->__construct() LibreBooking#6 [internal function]: ResourcesWebService->GetAll() LibreBooking#7 /var/www/html/lib/external/Slim/Router.php(200): call_user_func_array() LibreBooking#8 /var/www/html/lib/external/Slim/Slim.php(1218): Slim\Router->dispatch() LibreBooking#9 /var/www/html/lib/external/Slim/Middleware/Flash.php(86): Slim\Slim->call() LibreBooking#10 /var/www/html/lib/external/Slim/Middleware/MethodOverride.php(94): Slim\Middleware\Flash->call() LibreBooking#11 /var/www/html/lib/external/Slim/Middleware/PrettyExceptions.php(67): Slim\Middleware\MethodOverride->call() LibreBooking#12 /var/www/html/lib/external/Slim/Slim.php(1167): Slim\Middleware\PrettyExceptions->call() LibreBooking#13 /var/www/html/Web/Services/index.php(72): Slim\Slim->run() LibreBooking#14 {main}</pre></body></html>
The user would see "Unknown error" on the page. With this fix they now see the correct message of "You do not have permission to access one or more of the requested resources" Had got this error in the log when the user did not have access to any resources: Uncaught exception: TypeError: implode(): Argument #1 ($array) must be of type array, string given in /var/www/librebooking/lib/Common/SmartyPage.php:907 #0 /var/www/librebooking/lib/Common/SmartyPage.php(907): implode() #1 /var/www/librebooking/tpl_c/bdc8821f0b14313eaf56b1ea126646d5b4ea5097_0.file.schedule.tpl.php(506): SmartyPage->Implode() #2 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_669e13d3aee330_23010540() LibreBooking#3 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode() LibreBooking#4 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(217): Smarty_Template_Compiled->render() LibreBooking#5 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(238): Smarty_Internal_Template->render() LibreBooking#6 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(134): Smarty_Internal_TemplateBase->_execute() LibreBooking#7 /var/www/librebooking/Pages/Page.php(375): Smarty_Internal_TemplateBase->display() LibreBooking#8 /var/www/librebooking/Pages/SchedulePage.php(317): Page->Display() LibreBooking#9 /var/www/librebooking/Pages/ActionPage.php(32): SchedulePage->ProcessPageLoad() LibreBooking#10 /var/www/librebooking/Pages/SecurePage.php(171): ActionPage->PageLoad() LibreBooking#11 /var/www/librebooking/Web/schedule.php(8): SecurePageDecorator->PageLoad() LibreBooking#12 {main}
At the moment social logins, facebook and google sign-on, are using twinkletoes server. This dependency needs to be removed.
The text was updated successfully, but these errors were encountered: