ci: create an initial linting CI #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnVillalovos
force-pushed
the
jlvillal/init_ci
branch
10 times, most recently
from
3f1d080 to
b922dbc
Compare
This was inspired by: https://github.com/phpmyadmin/phpmyadmin/blob/b094f337466a1188ad755b33be5a7b7b25a70916/.github/workflows/lint-and-analyse-php.yml Resolve issues flagged by the syntax error checker: PHP Parse error: syntax error, unexpected token "new" in ./lib/external/pear/Event/Dispatcher.php on line 249 Errors parsing ./lib/external/pear/Event/Dispatcher.php PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in ./lib/external/pear/System.php on line 238 Errors parsing ./lib/external/pear/System.php PHP Parse error: syntax error, unexpected token "new" in ./lib/external/pear/Config/Container/XML.php on line 134 Errors parsing ./lib/external/pear/Config/Container/XML.php PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in ./lib/external/pear/Config/Container/IniCommented.php on line 167 Errors parsing ./lib/external/pear/Config/Container/IniCommented.php PHP Fatal error: __autoload() is no longer supported, use spl_autoload_register() instead in ./lib/external/FeedWriter/FeedWriter.php on line 432 Errors parsing ./lib/external/FeedWriter/FeedWriter.php
JohnVillalovos
force-pushed
the
jlvillal/init_ci
branch
from
b922dbc to
ee5bc0f
Compare
JohnVillalovos
added a commit
that referenced
this pull request
May 30, 2024
Got the following error: Slim Application Error The application could not run because of the following error: Details Code: 8192 Message:urlencode(): Passing null to parameter #1 ($string) of type string is deprecated File:/var/www/html/lib/Server/Url.php Line: 52 Trace: #0 [internal function]: Slim\Slim::handleErrors() #1 /var/www/html/lib/Server/Url.php(52): urlencode() #2 /var/www/html/lib/Application/Schedule/CalendarSubscriptionUrl.php(26): Url->AddQueryString() LibreBooking#3 /var/www/html/WebServices/Responses/ResourceResponse.php(82): CalendarSubscriptionUrl->__construct() LibreBooking#4 /var/www/html/WebServices/Responses/ResourcesResponse.php(20): ResourceResponse->__construct() LibreBooking#5 /var/www/html/WebServices/ResourcesWebService.php(65): ResourcesResponse->__construct() LibreBooking#6 [internal function]: ResourcesWebService->GetAll() LibreBooking#7 /var/www/html/lib/external/Slim/Router.php(200): call_user_func_array() LibreBooking#8 /var/www/html/lib/external/Slim/Slim.php(1218): Slim\Router->dispatch() LibreBooking#9 /var/www/html/lib/external/Slim/Middleware/Flash.php(86): Slim\Slim->call() LibreBooking#10 /var/www/html/lib/external/Slim/Middleware/MethodOverride.php(94): Slim\Middleware\Flash->call() LibreBooking#11 /var/www/html/lib/external/Slim/Middleware/PrettyExceptions.php(67): Slim\Middleware\MethodOverride->call() LibreBooking#12 /var/www/html/lib/external/Slim/Slim.php(1167): Slim\Middleware\PrettyExceptions->call() LibreBooking#13 /var/www/html/Web/Services/index.php(72): Slim\Slim->run() LibreBooking#14 {main}</pre></body></html>
JohnVillalovos
pushed a commit
that referenced
this pull request
Jul 26, 2024
The user would see "Unknown error" on the page. With this fix they now see the correct message of "You do not have permission to access one or more of the requested resources" Had got this error in the log when the user did not have access to any resources: Uncaught exception: TypeError: implode(): Argument #1 ($array) must be of type array, string given in /var/www/librebooking/lib/Common/SmartyPage.php:907 #0 /var/www/librebooking/lib/Common/SmartyPage.php(907): implode() #1 /var/www/librebooking/tpl_c/bdc8821f0b14313eaf56b1ea126646d5b4ea5097_0.file.schedule.tpl.php(506): SmartyPage->Implode() #2 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_669e13d3aee330_23010540() LibreBooking#3 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode() LibreBooking#4 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(217): Smarty_Template_Compiled->render() LibreBooking#5 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(238): Smarty_Internal_Template->render() LibreBooking#6 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(134): Smarty_Internal_TemplateBase->_execute() LibreBooking#7 /var/www/librebooking/Pages/Page.php(375): Smarty_Internal_TemplateBase->display() LibreBooking#8 /var/www/librebooking/Pages/SchedulePage.php(317): Page->Display() LibreBooking#9 /var/www/librebooking/Pages/ActionPage.php(32): SchedulePage->ProcessPageLoad() LibreBooking#10 /var/www/librebooking/Pages/SecurePage.php(171): ActionPage->PageLoad() LibreBooking#11 /var/www/librebooking/Web/schedule.php(8): SecurePageDecorator->PageLoad() LibreBooking#12 {main}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was copied for the most part from
https://github.com/phpmyadmin/phpmyadmin/blob/b094f337466a1188ad755b33be5a7b7b25a70916/.github/workflows/lint-and-analyse-php.yml