Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use PHP 8.1, 8.2, and 8.3 for doing syntax check #2

Closed
wants to merge 1 commit into from
Closed

ci: use PHP 8.1, 8.2, and 8.3 for doing syntax check #2

wants to merge 1 commit into from

Conversation

JohnVillalovos
Copy link
Owner

No description provided.

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/ci_php83 branch 2 times, most recently from 973cc6a to 4d6aae1 Compare May 30, 2024 23:54
JohnVillalovos added a commit that referenced this pull request Jun 14, 2024
@JohnVillalovos
fix: urlencode error with PHP 8.3
4b3b5b2 
Got the following error:

  Slim Application Error
  The application could not run because of the following error:
  Details
  Code: 8192
  Message:urlencode(): Passing null to parameter #1 ($string) of type string is deprecated
  File:/var/www/html/lib/Server/Url.php
  Line: 52
  Trace:
  #0 [internal function]: Slim\Slim::handleErrors()
  #1 /var/www/html/lib/Server/Url.php(52): urlencode()
  #2 /var/www/html/lib/Application/Schedule/CalendarSubscriptionUrl.php(26): Url->AddQueryString()
  LibreBooking#3 /var/www/html/WebServices/Responses/ResourceResponse.php(82): CalendarSubscriptionUrl->__construct()
  LibreBooking#4 /var/www/html/WebServices/Responses/ResourcesResponse.php(20): ResourceResponse->__construct()
  LibreBooking#5 /var/www/html/WebServices/ResourcesWebService.php(65): ResourcesResponse->__construct()
  LibreBooking#6 [internal function]: ResourcesWebService->GetAll()
  LibreBooking#7 /var/www/html/lib/external/Slim/Router.php(200): call_user_func_array()
  LibreBooking#8 /var/www/html/lib/external/Slim/Slim.php(1218): Slim\Router->dispatch()
  LibreBooking#9 /var/www/html/lib/external/Slim/Middleware/Flash.php(86): Slim\Slim->call()
  LibreBooking#10 /var/www/html/lib/external/Slim/Middleware/MethodOverride.php(94): Slim\Middleware\Flash->call()
  LibreBooking#11 /var/www/html/lib/external/Slim/Middleware/PrettyExceptions.php(67): Slim\Middleware\MethodOverride->call()
  LibreBooking#12 /var/www/html/lib/external/Slim/Slim.php(1167): Slim\Middleware\PrettyExceptions->call()
  LibreBooking#13 /var/www/html/Web/Services/index.php(72): Slim\Slim->run()
  LibreBooking#14 {main}</pre></body></html>
JohnVillalovos pushed a commit that referenced this pull request Jul 10, 2024
@jvillal-amp @JohnVillalovos
fix: passing null to explode() function
981862a 
When calling the `GetCategoryAttributes` API, got an error:

The application could not run because of the following error:
    Details
    Code: 8192
    Message: explode(): Passing null to parameter #2 ($string) of type string is deprecated
    File: /var/www/html/Domain/CustomAttribute.php
    Line: 137
JohnVillalovos pushed a commit that referenced this pull request Jul 26, 2024
@jvillal-amp @JohnVillalovos
fix: handle no resources case in schedule
3213ef8 
The user would see "Unknown error" on the page. With this fix they now
see the correct message of "You do not have permission to access one
or more of the requested resources"

Had got this error in the log when the user did not have access to any
resources:

  Uncaught exception: TypeError: implode(): Argument #1 ($array) must be of type array, string given in /var/www/librebooking/lib/Common/SmartyPage.php:907
  #0 /var/www/librebooking/lib/Common/SmartyPage.php(907): implode()
  #1 /var/www/librebooking/tpl_c/bdc8821f0b14313eaf56b1ea126646d5b4ea5097_0.file.schedule.tpl.php(506): SmartyPage->Implode()
  #2 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_669e13d3aee330_23010540()
  LibreBooking#3 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode()
  LibreBooking#4 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(217): Smarty_Template_Compiled->render()
  LibreBooking#5 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(238): Smarty_Internal_Template->render()
  LibreBooking#6 /var/www/librebooking/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(134): Smarty_Internal_TemplateBase->_execute()
  LibreBooking#7 /var/www/librebooking/Pages/Page.php(375): Smarty_Internal_TemplateBase->display()
  LibreBooking#8 /var/www/librebooking/Pages/SchedulePage.php(317): Page->Display()
  LibreBooking#9 /var/www/librebooking/Pages/ActionPage.php(32): SchedulePage->ProcessPageLoad()
  LibreBooking#10 /var/www/librebooking/Pages/SecurePage.php(171): ActionPage->PageLoad()
  LibreBooking#11 /var/www/librebooking/Web/schedule.php(8): SecurePageDecorator->PageLoad()
  LibreBooking#12 {main}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JohnVillalovos