feat(admission) enable the webhook by default and release 2.16 #727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
From conversation earlier today, we noted that admission webhook is useful but not enabled by default in deploy manifests. Enabling it by default in the plain manifests is difficult because we know of no way to have Kustomize generate the certificate, but Helm can generate a certificate.
The admission webhook was not enabled by default, but AFAIK this was just a safe default we chose when the webhook was newer and possibly buggier. At this point, the webhook is stable, works well, and only rejects configuration that Kong cannot accept anyway, so we should just go ahead and turn it on.
There was furthermore a chart limitation where the default generated certificate would force a Deployment restart on every upgrade. We've since added functionality that avoids this by checking if a certificate exists on upgrade and leaving it as-is, rather than always generating a fresh certificate.
Releases 2.16.
Special notes
We should maybe see if we can get #722 in first, so holding this for a day or so to see if we can get that in as well.
Checklist
main
branch.