Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admission) enable the webhook by default and release 2.16 #727

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jan 31, 2023

What this PR does / why we need it:

From conversation earlier today, we noted that admission webhook is useful but not enabled by default in deploy manifests. Enabling it by default in the plain manifests is difficult because we know of no way to have Kustomize generate the certificate, but Helm can generate a certificate.

The admission webhook was not enabled by default, but AFAIK this was just a safe default we chose when the webhook was newer and possibly buggier. At this point, the webhook is stable, works well, and only rejects configuration that Kong cannot accept anyway, so we should just go ahead and turn it on.

There was furthermore a chart limitation where the default generated certificate would force a Deployment restart on every upgrade. We've since added functionality that avoids this by checking if a certificate exists on upgrade and leaving it as-is, rather than always generating a fresh certificate.

Releases 2.16.

Special notes

We should maybe see if we can get #722 in first, so holding this for a day or so to see if we can get that in as well.

Checklist

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@rainest rainest requested a review from a team as a code owner January 31, 2023 17:39
@rainest rainest changed the title feat(admission) enable the webhook by default feat(admission) enable the webhook by default and release 2.16 Jan 31, 2023
pmalek
pmalek previously approved these changes Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants