doc(kic) update admission webhook documentation #5105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
added
do not merge
❌ Deploy Preview for kongdocs failed.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
app/_src/kubernetes-ingress-controller/deployment/admission-webhook.md
Outdated
Show resolved
Hide resolved
Call out the admission webhook more prominently in deploy documentation. Use "admission webook" consistently. Previously documentation used "admission webhook" and "admission controller" interchangeably. Add Helm chart instructions to the admission webhook documentation.
rainest
force-pushed
the
doc/admission
branch
from
bd742bb
to
8e971a3
Compare
app/_src/kubernetes-ingress-controller/deployment/admission-webhook.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/deployment/admission-webhook.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/deployment/admission-webhook.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/deployment/admission-webhook.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Diana <[email protected]>
cloudjumpercat
approved these changes
Feb 2, 2023
|
I apparently can't re-run checks on this repo, but it looks like the failures were all transient github issues, so ignoring. They were passing previously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Call out the admission webhook more prominently in deploy documentation.
Use "admission webook" consistently. Previously documentation used "admission webhook" and "admission controller" interchangeably.
Add Helm chart instructions to the admission webhook documentation.
Note: this references a chart version that is not yet released. It is ready for review but should not be merged until Kong/charts#727 is merged.
Testing instructions
None. No major changes to formatting, only some link updates that Vale should catch if I botched them
Checklist
mainfor immediate publishing, or a release branch: e.g.release/gateway-3.2,release/deck-1.17)