fix(ci): always ensure tests pass

[czeslavo]

No description provided.

[codecov-commenter]

Codecov Report

Base: 53.07% // Head: 52.45% // Decreases project coverage by -0.62% ⚠️

Coverage data is based on head (fee4c09) compared to base (5b3d5ca).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   53.07%   52.45%   -0.62%     
==========================================
  Files          50       50              
  Lines        3904     3904              
==========================================
- Hits         2072     2048      -24     
- Misses       1567     1598      +31     
+ Partials      265      258       -7     

Flag	Coverage Δ
integration-test	57.24% <ø> (-0.70%)	⬇️
unit-test	3.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/clusters/addons/metallb/metallb.go	56.72% <0.00%> (-10.09%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pmalek]

Locally TestKongAddonWithCustomImage also fails with the following logs in KIC:

time="2023-02-03T18:13:17Z" level=info msg="starting controller manager" commit=8990c5831546ff3b550393ba264afc37bef4e67d logger=setup release=2.3.0 repo="https://github.com/Kong/kubernetes-ingress-controller.git"
time="2023-02-03T18:13:17Z" level=info msg="getting enabled options and features" logger=setup
time="2023-02-03T18:13:17Z" level=info msg="getting the kubernetes client configuration" logger=setup
W0203 18:13:17.679454       1 client_config.go:617] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
time="2023-02-03T18:13:17Z" level=info msg="getting the kong admin api client configuration" logger=setup
time="2023-02-03T18:13:17Z" level=info msg="tag filtering enabled" logger=setup tags="[\"managed-by-ingress-controller\"]"
time="2023-02-03T18:13:17Z" level=info msg="configuring and building the controller manager" logger=setup
time="2023-02-03T18:13:17Z" level=info msg="DB-less mode detected, disabling leader election" logger=setup
time="2023-02-03T18:13:17Z" level=info msg="Metrics server is starting to listen" addr=":10255" logger=controller-runtime.metrics
time="2023-02-03T18:13:17Z" level=info msg="Starting Admission Server" logger=setup
Error: either cert/key files OR cert/key values must be provided, or none
Error: either cert/key files OR cert/key values must be provided, or none

[czeslavo]

@pmalek Kong/charts#727?

[pmalek]

It seems that kong addon in that test is configured (by default?) with Service of type LoadBalancer but since metallb is not deployed it can't get the IP and mark itself ready.

I have a PR for that in progress