Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://github.com/DangerKlippers/danger-klipper/issues/147 where pll_base is hard-coded to a value of 5 MHz, which works nominally for boards with a 25 MHz crystal on HSE but fails for 12 MHz and other values that do not evenly divide into 5 MHz when configuring the DIVM1 prescaler.
Thanks @dalegaard for the help.
May want to test against a board with a 25 MHz crystal before merging, and we may also want to check if this bug exists for other stm32 clock configs