Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Song lyrics do not work or is cut off #1461

Closed
1 of 2 tasks
GStudiosX2 opened this issue May 1, 2024 · 18 comments
Closed
1 of 2 tasks

Song lyrics do not work or is cut off #1461

GStudiosX2 opened this issue May 1, 2024 · 18 comments
Labels
bug Something isn't working

Comments

@GStudiosX2
Copy link

GStudiosX2 commented May 1, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Song lyrics seem to never have a synced option and usually plain is like cut off
Screenshot_20240501-224341
Screenshot_20240501-224338
And I have checked this song has synced lyrics in Spotify

Expected Behavior

To have synced or plain options if it has lyrics

Steps to reproduce

  1. Open the stable app
  2. Try to play a song
  3. Look at the lyrics tabs

Operating System

Android

Spotube version

v3.6.0 build 30

Installation source

Play Store (Android)

Additional information

What's weird is it worked yesterday

Self grab

  • I'm ready to work on this issue!
@GStudiosX2 GStudiosX2 added the bug Something isn't working label May 1, 2024
@GStudiosX2 GStudiosX2 changed the title Song lyrics Song lyrics do not work or is cut off May 1, 2024
@GStudiosX2
Copy link
Author

GStudiosX2 commented May 2, 2024 •
edited
Loading

Another song that doesn't work if you check on lrclib it has the lyrics https://lrclib.net/api/get?track_name=Stuck%20Inside&artist_name=Black%20Gryph0n,%20The%20Living%20Tombstone,%20Kevin%20Foster&album_name=Stuck%20Inside&duration=173 but you can't choose to switch to that

@KRTirtho KRTirtho moved this to Backlog in Spotube Board May 2, 2024
@KRTirtho
Copy link
Owner

KRTirtho commented May 2, 2024

That's a great find. I don't know how it got missed because I also remember it worked. Probably some kind of API change in the Spotify API

@GStudiosX2
Copy link
Author

Yeah probably is a Spotify API change but no clue what they changed

@GStudiosX2
Copy link
Author

GStudiosX2 commented May 2, 2024 •
edited
Loading

That's a great find. I don't know how it got missed because I also remember it worked. Probably some kind of API change in the Spotify API

Apparently they paywalled lyrics I saw this in some Discord server https://cdn.discordapp.com/attachments/937427930622070804/1234916057660133497/image.png?ex=66351bb3&is=6633ca33&hm=11c5a58728bd3a9e98bbb93ebfac458f49a1d4466da85ed5f5aada4ebf42762d& could be fake though but it's weird that it's cut off
Edit: wait though I think I saw the lyrics on Spotify?
Edit: I also found this X (twitter) post https://twitter.com/PopBase/status/1785770780816720236?ref_src=twsrc%5Etfw%7Ctwcamp%5Etweetembed%7Ctwterm%5E1785770780816720236%7Ctwgr%5E1dce33f5c1e9035782804384d3e8cdf5fc6ac4a3%7Ctwcon%5Es1_&ref_url=https%3A%2F%2Fmashable.com%2Farticle%2Fspotify-lyrics-pay-premium now

@GStudiosX2
Copy link
Author

Damn it's true I checked myself Screenshot_20240502-225236-511.png

@HaviOneEyedRaven
Copy link

So now we need third-party sources for lyrics more than ever, I guess.

@GStudiosX2
Copy link
Author

Yeah looks like it if the Spotify lyrics is gonna stay premium only

@KRTirtho KRTirtho mentioned this issue May 9, 2024
Closed
2 tasks
@Kannanlov
Copy link

(225)
help me

@bleonard252
Copy link
Contributor

(225) help me

This is already filed as a separate issue #1510 -- this appears to be charset-related.

@KRTirtho KRTirtho moved this from Backlog to In progress in Spotube Board May 23, 2024
@KRTirtho KRTirtho moved this from In progress to Done in Spotube Board May 23, 2024
KRTirtho added a commit that referenced this issue May 23, 2024
@KRTirtho
fix: fallback to LRCLIB when lyrics line less than 6 lines #1461
9aea354
@KRTirtho
Copy link
Owner

By default, Spotify API sends 5 lines of the whole lyrics maybe to show it as preview. From now on, Spotube will switch to LRCLIB when the line count <= 5

@TxTitan27
Copy link

By default, Spotify API sends 5 lines of the whole lyrics maybe to show it as preview. From now on, Spotube will switch to LRCLIB when the line count <= 5

Hey, Im still having this issue. Is it unable to be fixed? Cheers

@SomeoneL2
Copy link

By default, Spotify API sends 5 lines of the whole lyrics maybe to show it as preview. From now on, Spotube will switch to LRCLIB when the line count <= 5

Hey, Im still having this issue. Is it unable to be fixed? Cheers

Right now it is deployed in the nightly version of the app, till now not merged with the master branch of the app !

@TxTitan27
Copy link

TxTitan27 commented May 31, 2024 via email

@KRTirtho KRTirtho mentioned this issue Jun 1, 2024
Closed
2 tasks
@homointhechair
Copy link

The issue is not fixed on my end

@SamTees
Copy link

SamTees commented Jun 2, 2024

The issue is not fixed on my end

The fix hasn't been released yet

@SomeoneL2
Copy link

SomeoneL2 commented Jun 2, 2024 •
edited
Loading

Could you explain what the nightly version is? I'm not as technically inclined as some, haha
…
________________________________ From: SomeoneL2 @.> Sent: 31 May 2024 12:25 To: KRTirtho/spotube @.> Cc: TxTitan27 @.>; Comment @.> Subject: Re: [KRTirtho/spotube] Song lyrics do not work or is cut off (Issue #1461) By default, Spotify API sends 5 lines of the whole lyrics maybe to show it as preview. From now on, Spotube will switch to LRCLIB when the line count <= 5 Hey, Im still having this issue. Is it unable to be fixed? Cheers Right now it is deployed in the nightly version of the app, till now not merged with the master branch of the app ! — Reply to this email directly, view it on GitHub<#1461 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BIUEQDKALIYBHMWZ3BLN5S3ZFBMZ3AVCNFSM6AAAAABHCTP7MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRHAZDQMJRHA. You are receiving this because you commented.Message ID: @.***>

The nightly build of the app is made after each and every contribution to the app codebase,
In the nightly build, this issue has been solved.
you can download the nightly build from this link: https://github.com/KRTirtho/spotube/releases/tag/nightly

KRTirtho added a commit that referenced this issue Jun 3, 2024
@KRTirtho @GhoulBoii
@MerkomassDev @ksaadDE @josuigoa @osopromadze @ctih1 @ctih2 @yusriltakeuchi @mikropsoft @iAkashPattnaik @bleonard252
chore: Release v3.7.0 (#1552)
3aca737 
* chore: fix analyzer issues

* fix(updater): dead link (#1408)

* docs: broken link in README.md (fixes #1310) (#1311)

* docs: remove appimage link in readme #1082 (#1171)

* Updating Readme according to #1082

Updating Readme according to #1082

* Added explanation

The explanation is now given and the expression is more formal and explanatory, instead of just linking the issue.

* Update use_update_checker.dart

---------

Co-authored-by: MerkomassDev <[email protected]>
Co-authored-by: Karim <[email protected]>
Co-authored-by: Kingkor Roy Tirtho <[email protected]>

* fix(linux): tray icon not showing #541

upgrade old packages

* fix(search): load more button not working #1417

* fix: spotify friends and user profile icon (mobile) showing when not authenticated #1410

* chore: add docker and m1 based linux arm build

* cd: fix sed failing us

* cd: use docker cask

* fix: windows SSL Certificate error breaking login #905 (#1474)

* fix: certificate error by using custom ssl certificate

* Cd/docker linux ar (#1468)

* cd: use docker buildx

* cd: use linux host for linux arm instead of macos m1

m1 doesn't support nested virtualization. (Apple truly sucks)

* cd: don't specify arch in Dockerfile

* cd: use custom Dockerfile from ubuntu instead of flutter image

* cd: add setup java for android

* cd: add flutter distributor pre-built docker image for arm

* cd: save me from this cursed arm build

* cd: ??

* cd: ??

* cd: use docker build

* fix: windows SSL Exception for Signing in

* refactor: extract update checker as a basic function instead of a hook

* cd: fix windows build error due to nightly version format

* cd: fix github versioning scheme

* chore:  remove assets/ca entry in pubspec.yaml

* fix(macos): Logs directory not created by default #1353

* refactor: Dart based Github Workflow CLI (#1490)

* feat: add build dart script for windows

* feat: add android build support

* feat: add linux build support

* feat: add macos build support

* feat: add ios build support

* feat: add deps install command and workflow file

* cd: what?

* cd: what?

* cd: what?

* cd: update workflow inputs

* cd: replace release binary

* cd: run flutter pub get

* cd: use dpkg zstd instead of xz, windows disable innoInstall, fix channel enum.name and reset pubspec after changing build no for nightly

* cd: fix tar copy path

* cd: fix copy linux command

* cd: fix windows inno depend and fix android aab path

* cd: idk

* cd: linux why???

* cd: windows choco copy failed

* cd: use dart tar archive for creating tar file

* cd: fix linux file copy error

* cd: use tar command directly

* feat: add linux_arm platform

* cd: add linux_arm platform

* cd: don't know what?

* feat: notification about nightly channel update

* chore: fix some errors parsing nightly version info

* refactor: move dart scripts as commands under CLI

* chore: add translated message command to command list

* feat(translations): add Basque translation (#1493)

* added Basque translation

* chore: fix country codes and language native name

---------

Co-authored-by: Kingkor Roy Tirtho <[email protected]>

* feat(translations): add georgian language (#1450)

* feat: add georgian language

* feat: translate more georgian words

* feat(translations): add Finnish translations (#1449)

* docs: broken link in README.md (fixes #1310) (#1311)

* docs: remove appimage link in readme #1082 (#1171)

* Updating Readme according to #1082

Updating Readme according to #1082

* Added explanation

The explanation is now given and the expression is more formal and explanatory, instead of just linking the issue.

* added finnish translation

* chore: fix arb syntax errors and language in l10n entries

---------

Co-authored-by: MerkomassDev <[email protected]>
Co-authored-by: Karim <[email protected]>
Co-authored-by: Kingkor Roy Tirtho <[email protected]>
Co-authored-by: Onni Nevala <[email protected]>

* feat(translations): add Indonesian translation (#1426)

* docs: broken link in README.md (fixes #1310) (#1311)

* docs: remove appimage link in readme #1082 (#1171)

* Updating Readme according to #1082

Updating Readme according to #1082

* Added explanation

The explanation is now given and the expression is more formal and explanatory, instead of just linking the issue.

* Add Indonesia translation

---------

Co-authored-by: MerkomassDev <[email protected]>
Co-authored-by: Karim <[email protected]>
Co-authored-by: Kingkor Roy Tirtho <[email protected]>

* feat(translations): Improve tr locales (#1419)

* docs: broken link in README.md (fixes #1310) (#1311)

* docs: remove appimage link in readme #1082 (#1171)

* Updating Readme according to #1082

Updating Readme according to #1082

* Added explanation

The explanation is now given and the expression is more formal and explanatory, instead of just linking the issue.

* Improve tr locales

---------

Co-authored-by: MerkomassDev <[email protected]>
Co-authored-by: Karim <[email protected]>
Co-authored-by: Kingkor Roy Tirtho <[email protected]>

* feat(player): add volume slider floating label showing percentage (#1445)

* docs: broken link in README.md (fixes #1310) (#1311)

* docs: remove appimage link in readme #1082 (#1171)

* Updating Readme according to #1082

Updating Readme according to #1082

* Added explanation

The explanation is now given and the expression is more formal and explanatory, instead of just linking the issue.

* add volume level tooltip in volume_slider

---------

Co-authored-by: MerkomassDev <[email protected]>
Co-authored-by: Karim <[email protected]>
Co-authored-by: Kingkor Roy Tirtho <[email protected]>

* fix: fallback to LRCLIB when lyrics line less than 6 lines #1461

* feat: Local music library (#1479)

* feat: add one additional library folder

This folder just doesn't get downloaded to.
I think I'm going to rework it so that it can be multiple folders,
but I'm going to commit my progress so far anyway.

Signed-off-by: Blake Leonard <[email protected]>

* chore: update dependencies so that it builds

I'm not sure if this breaks CI or something, but I couldn't build
it locally to test my changes, so I made these changes and it
builds again.

Signed-off-by: Blake Leonard <[email protected]>

* feat: index multiple folders of local music

If you used a previous commit from this branch, this is a breaking
change, because it changes the type of a configuration field. but
since this is still in development, it should be fine.

Signed-off-by: Blake Leonard <[email protected]>

* refactor: manage local library in local tracks tab

This also refactors the list to use slivers instead. That's the
easiest way to have multiple scrolling lists here...

The console keeps getting spammed with some intermediate layout
error but I can't hold it long enough to figure out what's causing
it.

Signed-off-by: Blake Leonard <[email protected]>

* refactor: use folder add/remove icons in library

Signed-off-by: Blake Leonard <[email protected]>

* refactor: remove redundant settings page

Signed-off-by: Blake Leonard <[email protected]>

* refactor: rename "Local Tracks" to just "Local"

Not sure if this would be the recommended way to do it...

Signed-off-by: Blake Leonard <[email protected]>

* fix: console spam about useless Expanded

Signed-off-by: Blake Leonard <[email protected]>

* chore: remove completed TODO

Signed-off-by: Blake Leonard <[email protected]>

* chore: use new Platform constants; regenerate plugins

Signed-off-by: Blake Leonard <[email protected]>

* refactor: put local libraries on separate pages

Signed-off-by: Blake Leonard <[email protected]>

---------

Signed-off-by: Blake Leonard <[email protected]>

* fix: local track not showing up in queue

* feat: local library folder cards

* feat: personalized stats based on local music history (#1522)

* feat: add playback history provider

* feat: implement recently played section

* refactor: use route names

* feat: add stats summary and top tracks/artists/albums

* feat: add top date based filtering

* feat: add stream money calculation

* refactor: place search in mobile navbar and settings in home appbar

* feat: add individual minutes and streams page

* feat(stats): add individual minutes and streams page

* chore: default period to 1 month

* feat: add text to explain user how hypothetical fees are calculated

* chore: ensure usage of route names instead of direct paths

* cd: add cache key

* cd: remove media_kit_event_loop from git

* fix: some text are garbled in different parts of the app #1463 #1505

* refactor: use replace http with dio and use it as the default

* cd: use dio in cli as well

* chore: fix home feed not showing up

* chore: downloaded tracks folder not opening

* feat: play initially available tracks of playlist/album immediately and fetch rest in background #670

* feat: upgrade to Flutter 3.22.0

* refactor: migrate deprecated warnings

* fix(playback): skipping tracks with unplayable sources instead of falling back #1492

* chore: migrate android gradle to declarative config syntax

* chore: disable impeller for now

* fix(windows): installer tries to install in current directory

* chore: upgrade deps and appbar bg fix

* chore: podspec update

* chore: bump version and generate changelogs

---------

Signed-off-by: Blake Leonard <[email protected]>
Co-authored-by: Kshamendra <[email protected]>
Co-authored-by: MerkomassDev <[email protected]>
Co-authored-by: Karim <[email protected]>
Co-authored-by: Josu Igoa <[email protected]>
Co-authored-by: Omari Sopromadze <[email protected]>
Co-authored-by: ctih <[email protected]>
Co-authored-by: Onni Nevala <[email protected]>
Co-authored-by: Yusril Rapsanjani <[email protected]>
Co-authored-by: W͏ I͏ N͏ Z͏ O͏ R͏ T͏ <[email protected]>
Co-authored-by: Akash Pattnaik <[email protected]>
Co-authored-by: Blake Leonard <[email protected]>
@KRTirtho KRTirtho mentioned this issue Jun 3, 2024
Closed
2 tasks
@Mubelotix
Copy link

This needs to be reopened

@TxTitan27
Copy link

This needs to be reopened

It's been fixed with the latest update dropped today, at least on my end. My neighbours aren't impressed.

@KRTirtho KRTirtho moved this from Done to Deployed in Spotube Board Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Spotube Board
Status: Deployed
Milestone
No milestone
Development

No branches or pull requests
10 participants
@bleonard252 @SamTees @Mubelotix @KRTirtho @GStudiosX2 @SomeoneL2 @homointhechair @HaviOneEyedRaven @Kannanlov @TxTitan27