Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyric Source Selection #1464

Closed
1 of 2 tasks
Ocean-OS opened this issue May 3, 2024 · 6 comments
Closed
1 of 2 tasks

Lyric Source Selection #1464

Ocean-OS opened this issue May 3, 2024 · 6 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@Ocean-OS
Copy link

Ocean-OS commented May 3, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Pain

As the lyrics system has changed, and some sources have bugs, and some sources are just better than others, it'd be nice to be able to choose what source is the priority for lyrics.

Suggested solution

I was thinking that there could be one of two options:

  • A dropdown selection for lyric source, like the music source selection in settings
  • A button in settings, that lets you sort music sources in a list, based on priority (if a song doesn't have lyrics available from the first priority source, try the second priority source, and so on)

Useful resources

No response

Additional information

No response

Self grab

  • I'm ready to work on this issue!
@Ocean-OS Ocean-OS added the enhancement New feature or request label May 3, 2024
@KRTirtho
Copy link
Owner

KRTirtho commented May 5, 2024

Spotify Lyrics are considered the best match and if it have both Synced and static lyrics, it'll be selected by default.
LRCLIB.net works as a fallback now already. Becuase LRCLIB usually has popular tracks, but regional ones (except US, CA, UK, Sweden) are much better found on Spotify and that doesn't require Premium, luckily

  • A button in settings, that lets you sort music sources in a list, based on priority (if a song doesn't have lyrics available from the first priority source, try the second priority source, and so on)

Audio Source has nothing to do with the Lyrics. Lyrics are directly matched using Spotify Track title and primary artist for LRCLIB and track id for Spotify (Musixmatch) itself

@makoto-kokoroki
Copy link

You definitely have to have Spotify Premium now for lyrics to work, so...

@KRTirtho
Copy link
Owner

KRTirtho commented May 6, 2024

Yup, so if it detects there's no lyrics, it'll switch to LRCLIB automatically.

@Kaympe20
Copy link

Kaympe20 commented May 9, 2024

@KRTirtho Because Spotify does provide the first 4 lines as static lyricss, LRCLIB is not automatically chosen when it should be.

@KRTirtho
Copy link
Owner

KRTirtho commented May 9, 2024

Ok, so it's the same issue of #1461. In that case we've check if it's more than 4 lines or not (or something similar).

@KRTirtho
Copy link
Owner

KRTirtho commented May 9, 2024

The thread will continue there. Thus closing it as duplicate (sorta)

@KRTirtho KRTirtho closed this as completed May 9, 2024
@KRTirtho KRTirtho added the duplicate This issue or pull request already exists label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants