Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandoc-crossref 0.3.17.1a #8892

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

palday
Copy link
Contributor

@palday palday commented Jun 14, 2024

@giordano should I just bump the version to 0.3.18? That doesn't seem quite right because it's still pandoc-crossref 0.3.17, but the build number is important to distinguish which version of pandoc it was compiled against (and that's why 0.3.17 already exists as a JLL -- it was compiled against an older version of pandoc)

@palday palday force-pushed the pa/pandoc_crossref-0.3.17.1a branch from 52e8ed2 to 2fbdade Compare June 14, 2024 05:24
@omus
Copy link
Contributor

omus commented Jun 14, 2024

I've set a Dependency on pandoc_jll as pandoc-crossref requires a specific version of pandoc to be installed or will produce a "ton of warnings". Having this declared as a dependency in Julia should avoid seeing those warnings.

Additionally, with this dependency in place we can leave the version number as 0.3.17 which matches the version set in pandoc-crossref. Now when a user requests a specific version of pandoc_jll the correct version of pandoc_crossref_jll will be installed.

@omus omus requested a review from giordano June 14, 2024 15:08
@giordano giordano merged commit 12eca6d into JuliaPackaging:master Jun 14, 2024
7 checks passed
@palday palday deleted the pa/pandoc_crossref-0.3.17.1a branch June 14, 2024 15:31
@omus
Copy link
Contributor

omus commented Jun 14, 2024

Unfortunately Pkg.jl doesn't use separate compat entries for each build which means the latest build updates the compat entries for all of 0.3.17. We're yanking the problematic release here: JuliaRegistries/General#109007.

It looks like we'll have to define a new version convention for this JLL.

amontoison pushed a commit that referenced this pull request Jun 22, 2024
* pandoc-crossref 0.3.17.1a

* Update build_tarballs.jl

* Set compatibility with pandoc_jll

---------

Co-authored-by: Curtis Vogt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants