Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeDependency's compat entry missing from Project.toml #1330

Open
omus opened this issue Jun 14, 2024 · 3 comments
Open

RuntimeDependency's compat entry missing from Project.toml #1330

omus opened this issue Jun 14, 2024 · 3 comments
Labels

Comments

@omus
Copy link
Contributor

omus commented Jun 14, 2024

The optional keyword argument compat can be used to specify a string for use in the Project.toml of the generated Julia package.

https://docs.binarybuilder.org/stable/reference/#BinaryBuilderBase.RuntimeDependency

I was trying to add a RuntimeDependency for pandoc_crossref and have found that the compat entry is ignored.

Specifically I added:

RuntimeDependency(PackageSpec(name="pandoc_jll"), compat="=3.2.0")

and then ran:

julia build_tarballs.jl --verbose --deploy=local x86_64-linux-gnu && cat ~/.julia/dev/pandoc_crossref_jll/Project.toml

Which resulted in this Project.toml:

name = "pandoc_crossref_jll"
uuid = "f96e3c25-ae70-5588-8d8e-4a7ab3ba4c45"
version = "0.3.17+1"

[deps]
JLLWrappers = "692b3bcd-3c85-4b1f-b108-f13ce0eb3210"
pandoc_jll = "c5432543-76ad-5c9d-82bf-db097047a5e2"
Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
Artifacts = "56f22d72-fd6d-98f1-02f0-08ddc0907c33"

[compat]
JLLWrappers = "1.2.0"
julia = "1.6"
Libdl = "1"
Artifacts = "1"
@omus
Copy link
Contributor Author

omus commented Jun 14, 2024

I also tried using top_level=true which didn't make a difference

@omus
Copy link
Contributor Author

omus commented Jun 14, 2024

Encountered this problem while working on: JuliaPackaging/Yggdrasil#8892

@giordano
Copy link
Member

giordano commented Jun 14, 2024

This is of course not intended. If I have to blindly guess, perhaps something is going wrong during serialisation/deserialisation: https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/406ec5c26348a7965cdc35aba15c03f84c02b525/src/Dependencies.jl#L341-L380. I thought this may be related to JuliaPackaging/Yggdrasil#8211, but in that case the package is added as Dependency, so I'm not sure anymore this is the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants