Changed Caption of last -Next button in Windows InstallationWizard to -Install button #48537

AbhaySingh004 · 2023-02-05T11:49:00Z

closes #48521
Bug Description-

Here the Next button should be replaced with Install

the Windows-Installer-Wizard shows the Install button on the ReadyPage of other software
as provided attachments in #48521

Bug Fix-

-now to solve this bug

in builder.iss inno-Setup-Script file the disablereadypage=yes is not making Installation-Wizard reach its readypage .

so to fix this I gone through Setup guide of Inno-Setup-Script and found the solution
link-

like show here in attachment below

…instead of next button

AbhaySingh004 · 2023-02-05T12:21:41Z

https://jrsoftware.org/ishelp/topic_setup_disablereadypage.htm
this is the link of Inno-Setup guide.
which shows how to handle DisableReadyPage=yes instruction to get install button currentWizardform

giordano · 2023-02-05T12:31:25Z

Hi, thanks for your contribution. Can you please give the pull request a more descriptive title?

AbhaySingh004 · 2023-02-05T12:53:01Z

Hi, thanks for your contribution. Can you please give the pull request a more descriptive title?

thank you for your guidance. I have edited the title
Do you think it's good now? Or should I be more descriptive?

AbhaySingh004 · 2023-02-05T13:10:16Z

contrib/windows/build-installer.iss

@@ -147,6 +147,12 @@ end;

 procedure CurPageChanged(CurPageID: Integer);
 begin
+  ;  Fixing bug in git Issue #48521


The comments would better describe the behaviour of the following code directly. Something like: change button text from next to install when there are no more options.

yes Surely, thank you for the suggestion.
i did changed the comment.

My bad for not expressing myself clearly.

Delete line 150 ~ line 155. Line 160 can replace them completely.

yes got it!
i hope its ready to merge now.

inkydragon · 2023-02-05T14:11:45Z

contrib/windows/build-installer.iss

@@ -147,6 +147,12 @@ end;

 procedure CurPageChanged(CurPageID: Integer);
 begin
+  ;  change button text from "next" to "install" when ReadyPage is disabled.
+  if CurPageID = wpSelectProgramGroup then


For example, if the new last pre-installation wizard page is the Select Program Group page:

Our last page is wpSelectTasks.

inkydragon · 2023-02-05T14:13:26Z

contrib/windows/build-installer.iss

+  if CurPageID = wpSelectProgramGroup then
+    WizardForm.NextButton.Caption := SetupMessage(msgButtonInstall)
+  else
+    WizardForm.NextButton.Caption := SetupMessage(msgButtonNext);


This will override the button "Finish" on the final page.

contrib/windows/build-installer.iss

Co-authored-by: woclass <[email protected]>

AbhaySingh004 · 2023-02-05T14:33:10Z

i commited @inkydragon the changes you suggested.

inkydragon · 2023-02-05T14:41:56Z

I mean, just add a new branch for that case.
The if-else code block can be removed.

For other reviewer

You don't need to build julia, a new folder and a fake exe is enough to complete the package test.

# In JuliaLang/julia/

# download innosetup
make win-extras

# make fake binary dir
mkdir -p julia-innosetup/bin/
# make fake exe
echo 1 > julia-innosetup/bin/julia.exe

Run this in MSYS2, Or you may need to manually combine the full path, for example by packing it in cmd

# pack installer
MSYS2_ARG_CONV_EXCL='*'  ./dist-extras/inno/iscc.exe /DAppVersion=1.10.0-DEV /DSourceDir="`cygpath -w -a ./julia-innosetup`" /DRepoDir="`cygpath -w -a .`" /O"`cygpath -w -a .`"  "`cygpath -w -a ./contrib/windows/build-installer.iss`"

AbhaySingh004 · 2023-02-05T15:07:43Z

hey @inkydragon, I am new to the open source community.
I want some guidance on this
Just a query for a new branch, do I have to create a new Pull Request?

inkydragon · 2023-02-05T15:18:55Z

My bad for not expressing myself clearly.

Delete line 150 ~ line 155.
Line 160 can replace them completely.

inkydragon · 2023-02-06T15:17:12Z

contrib/windows/build-installer.iss

@@ -145,11 +145,15 @@ begin
  end;
 end;

+


Suggested change

inkydragon · 2023-02-06T15:17:25Z

contrib/windows/build-installer.iss

 procedure CurPageChanged(CurPageID: Integer);
 begin
  case CurPageID of
    wpWelcome: WizardForm.Color := WizardForm.WelcomePage.Color;
    wpFinished: WizardForm.Color := WizardForm.FinishedPage.Color;
+
+    ;change button text from "next" to "install" when ReadyPage is disabled.


Suggested change

;change button text from "next" to "install" when ReadyPage is disabled.

// change button text from "next" to "install" when ReadyPage is disabled.

thank You So much @inkydragon for helping me out with this.
I committed the changes you suggested, is it alright now?

inkydragon

I have tested this pr locally and it looks fine.
cc: @staticfloat

staticfloat · 2023-02-06T20:14:37Z

Great, thanks! Welcome to the Julia community, @AbhaySingh004!

Builder-installer.iss modified to show install button in wizard form …

0fffc25

…instead of next button

DilumAluthge requested a review from davidanthoff February 5, 2023 11:50

DilumAluthge added the system:windows Affects only Windows label Feb 5, 2023

DilumAluthge requested a review from staticfloat February 5, 2023 11:50

AbhaySingh004 changed the title ~~Windows-InstallationWizard-Form-BugFix~~ Changed Caption of last -Next button in Windows InstallationWizard to -Install button Feb 5, 2023

inkydragon reviewed Feb 5, 2023

View reviewed changes

build-installer.iss modified the comments

6ea92b4

AbhaySingh004 requested review from inkydragon and removed request for staticfloat and davidanthoff February 5, 2023 13:12

inkydragon reviewed Feb 5, 2023

View reviewed changes

Update contrib/windows/build-installer.iss

253e825

Co-authored-by: woclass <[email protected]>

build-installer.iss modified overiding the finish page bug removed

4cfa0fc

AbhaySingh004 added 2 commits February 5, 2023 20:55

modified builder-installer.iss with removing if-else block

a62d7bb

modified builder-installer.iss with removing if-else block

850dc2a

inkydragon reviewed Feb 6, 2023

View reviewed changes

contrib/windows/build-installer.iss Outdated

@@ -145,11 +145,15 @@ begin

end;

end;

Copy link

Member

inkydragon Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

inkydragon reviewed Feb 6, 2023

View reviewed changes

modified builder-installer.iss correcting the comment with right syntax

bba0a1e

inkydragon approved these changes Feb 6, 2023

View reviewed changes

inkydragon added the building Build system, or building Julia or its dependencies label Feb 6, 2023

staticfloat merged commit 8860d95 into JuliaLang:master Feb 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed Caption of last -Next button in Windows InstallationWizard to -Install button #48537

Changed Caption of last -Next button in Windows InstallationWizard to -Install button #48537

AbhaySingh004 commented Feb 5, 2023

AbhaySingh004 commented Feb 5, 2023

giordano commented Feb 5, 2023

AbhaySingh004 commented Feb 5, 2023

This comment was marked as resolved.

AbhaySingh004 Feb 5, 2023

AbhaySingh004 Feb 5, 2023

inkydragon Feb 5, 2023

inkydragon Feb 5, 2023

AbhaySingh004 commented Feb 5, 2023

inkydragon commented Feb 5, 2023 •

edited

Loading

AbhaySingh004 commented Feb 5, 2023 •

edited

Loading

inkydragon commented Feb 5, 2023

inkydragon Feb 6, 2023

inkydragon Feb 6, 2023

AbhaySingh004 Feb 6, 2023

inkydragon left a comment

staticfloat commented Feb 6, 2023

	;change button text from "next" to "install" when ReadyPage is disabled.
	// change button text from "next" to "install" when ReadyPage is disabled.

Changed Caption of last -Next button in Windows InstallationWizard to -Install button #48537

Changed Caption of last -Next button in Windows InstallationWizard to -Install button #48537

Conversation

AbhaySingh004 commented Feb 5, 2023

AbhaySingh004 commented Feb 5, 2023

giordano commented Feb 5, 2023

AbhaySingh004 commented Feb 5, 2023

This comment was marked as resolved.

AbhaySingh004 Feb 5, 2023

Choose a reason for hiding this comment

AbhaySingh004 Feb 5, 2023

Choose a reason for hiding this comment

inkydragon Feb 5, 2023

Choose a reason for hiding this comment

inkydragon Feb 5, 2023

Choose a reason for hiding this comment

AbhaySingh004 commented Feb 5, 2023

inkydragon commented Feb 5, 2023 • edited Loading

For other reviewer

AbhaySingh004 commented Feb 5, 2023 • edited Loading

inkydragon commented Feb 5, 2023

inkydragon Feb 6, 2023

Choose a reason for hiding this comment

inkydragon Feb 6, 2023

Choose a reason for hiding this comment

AbhaySingh004 Feb 6, 2023

Choose a reason for hiding this comment

inkydragon left a comment

Choose a reason for hiding this comment

staticfloat commented Feb 6, 2023

inkydragon commented Feb 5, 2023 •

edited

Loading

AbhaySingh004 commented Feb 5, 2023 •

edited

Loading