Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Caption of last -Next button in Windows InstallationWizard to -Install button #48537

Merged
merged 7 commits into from
Feb 6, 2023
Merged

Changed Caption of last -Next button in Windows InstallationWizard to -Install button #48537

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0fffc25
Builder-installer.iss modified to show install button in wizard form …
AbhaySingh004 Feb 5, 2023
6ea92b4
build-installer.iss modified the comments
AbhaySingh004 Feb 5, 2023
253e825
Update contrib/windows/build-installer.iss
AbhaySingh004 Feb 5, 2023
4cfa0fc
build-installer.iss modified overiding the finish page bug removed
AbhaySingh004 Feb 5, 2023
a62d7bb
modified builder-installer.iss with removing if-else block
AbhaySingh004 Feb 5, 2023
850dc2a
modified builder-installer.iss with removing if-else block
AbhaySingh004 Feb 5, 2023
bba0a1e
modified builder-installer.iss correcting the comment with right syntax
AbhaySingh004 Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contrib/windows/build-installer.iss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,15 @@ begin
end;
end;


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

procedure CurPageChanged(CurPageID: Integer);
begin
case CurPageID of
wpWelcome: WizardForm.Color := WizardForm.WelcomePage.Color;
wpFinished: WizardForm.Color := WizardForm.FinishedPage.Color;
AbhaySingh004 marked this conversation as resolved.
Show resolved Hide resolved

;change button text from "next" to "install" when ReadyPage is disabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
;change button text from "next" to "install" when ReadyPage is disabled.
// change button text from "next" to "install" when ReadyPage is disabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank You So much @inkydragon for helping me out with this.
I committed the changes you suggested, is it alright now?

wpSelectTasks: WizardForm.NextButton.Caption := SetupMessage(msgButtonInstall);
else
WizardForm.Color := WizardForm.InnerPage.Color;
end;
Expand Down