Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The last Next button in Windows installer should say Install instead #48521

Closed
kdheepak opened this issue Feb 4, 2023 · 1 comment · Fixed by #48537
Closed

The last Next button in Windows installer should say Install instead #48521

kdheepak opened this issue Feb 4, 2023 · 1 comment · Fixed by #48537
Labels
system:windows Affects only Windows

Comments

@kdheepak
Copy link
Contributor

kdheepak commented Feb 4, 2023 •
edited
Loading

Right now the Next button in the Select additional tasks screen is not clear that it is going to install Julia when you hit Next.

image

I think it'd be a better UX if it said Install instead.

For reference, this is what git does on the very last screen of its options:

image

vscode goes on step further and summarizes all the "additional tasks" that were selected in the previous screen.

image
@giordano giordano added the system:windows Affects only Windows label Feb 4, 2023
@inkydragon
Copy link
Member

I guess reopening the "Ready page" would be enough.

julia/contrib/windows/build-installer.iss

Line 79 in 07c4244

DisableReadyPage=yes 

-DisableReadyPage=yes
+DisableReadyPage=no

@AbhaySingh004 AbhaySingh004 mentioned this issue Feb 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
system:windows Affects only Windows
Projects
None yet
Milestone
No milestone
3 participants
@giordano @kdheepak @inkydragon