Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: doc style tweaks #2123

Closed
wants to merge 14 commits into from
Closed

WIP: doc style tweaks #2123

wants to merge 14 commits into from

Conversation

nolta
Copy link
Member

@nolta nolta commented Jan 25, 2013

I've been fooling around with some tweaks to the doc style, mostly to fix #1422 and #2012, but also to spruce things up a bit. You can see what it looks like here: http://julia-demo.readthedocs.org/.

@Keno
Copy link
Member

Keno commented Jan 25, 2013

I like it. Very nice and clean.

@StefanKarpinski
Copy link
Member

Looks very nice. I found this amusing:

Screen Shot 2013-01-24 at 10 53 51 PM

It's a little spacey, imo, especially already-sparse pages like the package list.

@ViralBShah
Copy link
Member

Is there something we can do so that package documentation also follows the same framework as julia itself, and links to package documentation show up on docs.julialang.org? Perhaps for every package, we can then also link to its documentation.

@aviks
Copy link
Member

aviks commented Jan 25, 2013

It looks good!

However, I personally think Lato is quite a dense font, and large blocks of text in Lato improves from the addition of a slight greyness, maybe

body {color: #777}

which still provides enough contrast on a white background.

@nolta
Copy link
Member Author

nolta commented Jan 28, 2013

@StefanKarpinski: ok, removed the module index. As for the "spaciness", i added padding to h1 & h2 as i thought it improved the manual layout; can be dialed back if excessive.

@ViralBShah: we could split doc/_themes/julia into a separate repo, and then people could include it as a submodule of their package.

@aviks: hmm, i'm not a big fan of gray text. Probably better to just pick a different typeface. I'm certainly not wedded to Lato.

@StefanKarpinski
Copy link
Member

Ok, cool, let's dial it back a bit. I can mess with it at some point and suggest some changes. Very slightly gray can be easy on the eyes, but not so much that it's easy to tell this it's less than black.

@ViralBShah
Copy link
Member

Should this be updated to merge now?

@nolta
Copy link
Member Author

nolta commented Feb 20, 2013

I was planning to merge --squash this if it got accepted. The commit history isn't very clean.

@StefanKarpinski
Copy link
Member

My big concern with this is that now the look-and-feel doesn't match the main home page at all. In general, keeping the two in sync is kind of a nightmare. But if you're willing to meet the home page halfway and make this something that looks ok with the new tentative Julia logo and favicon, then I'm fine with it. It's clearly a nicer design, although it feels a bit technical, heavy and masculine to me. Perhaps you could cherry-pick some of the less invasive changes, lighten the bar at the top, and merge that?

@nolta
Copy link
Member Author

nolta commented Feb 20, 2013

Ok, how's this: http://julia-demo.readthedocs.org/

@diegozea
Copy link
Contributor

I don't like red color on links.
Pages with too much links looks too red.

Red is a warning color. Maybe a more soft color for links ?
Blue is the typical, maybe the same blue of the point over the J of Julia logo ?

@StefanKarpinski
Copy link
Member

I have to agree with @diegozea about the red links. Maybe a lighter and darker shade of gray for clicked and unclicked links?

@StefanKarpinski
Copy link
Member

But yes, otherwise this is good.

@nolta
Copy link
Member Author

nolta commented Feb 21, 2013

Fair enough. I've switched them to blue, but gray would work too.

@diegozea
Copy link
Contributor

I like the new version +1

@pao
Copy link
Member

pao commented Mar 2, 2013

@nolta @StefanKarpinski anything other then a merge conflict holding this up?

@ViralBShah
Copy link
Member

I think we should merge this. Anything holding us up still?

nolta added a commit to JuliaLang/JuliaDoc that referenced this pull request May 27, 2013
@pao
Copy link
Member

pao commented May 27, 2013

This is all merged into JuliaLang/JuliaDoc and the patches in #2379 now.

@pao pao closed this May 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar occludes main text when zooming in mobile browsers
7 participants