-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: doc style tweaks #2123
WIP: doc style tweaks #2123
Conversation
Conflicts: doc/Makefile doc/stdlib/index.rst
I like it. Very nice and clean. |
Is there something we can do so that package documentation also follows the same framework as julia itself, and links to package documentation show up on docs.julialang.org? Perhaps for every package, we can then also link to its documentation. |
It looks good! However, I personally think Lato is quite a dense font, and large blocks of text in Lato improves from the addition of a slight greyness, maybe body {color: #777} which still provides enough contrast on a white background. |
@StefanKarpinski: ok, removed the module index. As for the "spaciness", i added padding to h1 & h2 as i thought it improved the manual layout; can be dialed back if excessive. @ViralBShah: we could split @aviks: hmm, i'm not a big fan of gray text. Probably better to just pick a different typeface. I'm certainly not wedded to Lato. |
Ok, cool, let's dial it back a bit. I can mess with it at some point and suggest some changes. Very slightly gray can be easy on the eyes, but not so much that it's easy to tell this it's less than black. |
Also fix a couple of minor layout errors.
Should this be updated to merge now? |
I was planning to |
My big concern with this is that now the look-and-feel doesn't match the main home page at all. In general, keeping the two in sync is kind of a nightmare. But if you're willing to meet the home page halfway and make this something that looks ok with the new tentative Julia logo and favicon, then I'm fine with it. It's clearly a nicer design, although it feels a bit technical, heavy and masculine to me. Perhaps you could cherry-pick some of the less invasive changes, lighten the bar at the top, and merge that? |
Ok, how's this: http://julia-demo.readthedocs.org/ |
I don't like red color on links. Red is a warning color. Maybe a more soft color for links ? |
I have to agree with @diegozea about the red links. Maybe a lighter and darker shade of gray for clicked and unclicked links? |
But yes, otherwise this is good. |
Fair enough. I've switched them to blue, but gray would work too. |
I like the new version +1 |
@nolta @StefanKarpinski anything other then a merge conflict holding this up? |
I think we should merge this. Anything holding us up still? |
Signed-off-by: Patrick O'Leary <[email protected]>
This is all merged into JuliaLang/JuliaDoc and the patches in #2379 now. |
I've been fooling around with some tweaks to the doc style, mostly to fix #1422 and #2012, but also to spruce things up a bit. You can see what it looks like here: http://julia-demo.readthedocs.org/.