Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Minor consistency updates #2449

Closed
wants to merge 5 commits into from

Conversation

jayschwa
Copy link
Member

@jayschwa jayschwa commented Mar 3, 2013

Minor changes which improve docs.julialang.org's consistency with julialang.org.

@pao
Copy link
Member

pao commented Mar 3, 2013

This probably conflicts with #2123? Also, the fork banner doesn't make any sense on the docs page.

@jayschwa
Copy link
Member Author

jayschwa commented Mar 3, 2013

I suppose not, but the banner is included on every other section of the site, even pages where it may not make sense (e.g. downloads or blog).

@pao
Copy link
Member

pao commented Mar 3, 2013

Still, a foolish consistency and all that. @nolta should probably be the one to check this all out though.

@jayschwa
Copy link
Member Author

jayschwa commented Mar 3, 2013

It looks like the addition of DejaVu Serif and favicon are still applicable to @nolta's branch. It might be better if the favicon source is http://julialang.org/favicon.ico so there isn't a duplicate copy, but I wasn't sure how to do that from within the Sphinx config.

@pao
Copy link
Member

pao commented Mar 3, 2013

Looks like the <link rel="shortcut icon"...> bit is in the basic layout template that the Julia theme extends: https://bitbucket.org/birkenfeld/sphinx/src/tip/sphinx/themes/basic/layout.html

@nolta
Copy link
Member

nolta commented Mar 4, 2013

Thanks Jay! I cherry picked the first two commits, and vetoed the fork patch. The favicon patch is fine, but i'd rather we store the file somewhere else.

@nolta nolta closed this Mar 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants