-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.4, RFC] backports for 0.4.2 #14186
Conversation
…ks around this issue (cherry picked from commit af81d6c)
…skip] (cherry picked from commit 8f21bd3)
You'll need access to the key and passphrase, talk to me or Elliot if the need arises [av skip] (cherry picked from commit c75d146)
Changes in convert(::BitArray, ::AbstractArray) and dumpbitcache(): * avoid branches in for loops * pack 8 Bools at a time * use inbounds (cherry picked from commit d7cd023)
(cherry picked from commit 7fee9ab)
(cherry picked from commit adff4be)
(cherry picked from commit b2459a6)
(cherry picked from commit 7ddd164) also pull in a new test in test/core.jl because why not, it seems to pass
I just restarted the Travis build to see if it shows up again. |
Which OS? |
Linux 64. It's a bit unreliable to bisect since it happens somewhat rarely, but my suspicion is it's most likely 8b3c67b |
Let's also make sure this doesn't exhibit #14245. |
Is it the same failure every time? |
Not sure. These logs are long and slightly out of order because of the redirection to get stdout and stderr to go to the same file: https://gist.github.com/edeec37dc129f2a5c2f2 There are some conversion errors and bounds errors here https://gist.githubusercontent.com/anonymous/edeec37dc129f2a5c2f2/raw/51db4fbb6d7895b723fe5b6994d19539fe8d0f7c/tests-74dcb330dd76ecad44739dac36229616d71ce557.log and an UndefRefError here https://gist.githubusercontent.com/anonymous/edeec37dc129f2a5c2f2/raw/51db4fbb6d7895b723fe5b6994d19539fe8d0f7c/tests-cbebbb71b58531c6aa00906188363886955acaa0.log |
8b3c67b is a hygiene fix. We can try reverting that, but the issue actually seems to be a memory corruption. |
FWIW, Something in the Travis environment is triggering this? |
Or possibly something caused by a different earlier test executed on the same worker? |
That does not hold true for the parallel test. Lines 14 to 16 in 071390a
|
It took a few hours, but 50 runs of
|
I think it might be that my openblas patch should be windows only. Needs looking into upstream to see if the next release is going to have this same issue. |
though until I backport #13569, travis should be using the ppa for openblas so that doesn't make much sense |
(cherry picked from commit b0cf837)
(cherry picked from commit a4f2e2e)
when an old PR build gets restarted after some time, the travis API request might not return enough builds to include the most recent one for the PR, so the null result would incorrectly cause a 'superceded' fast-fail condition (cherry picked from commit 111f5e5)
374894b
to
e3d08e6
Compare
If this passes on Travis and AppVeyor, I think it's ready to merge and tag. If it doesn't, please copy and save the Travis logs to a gist before restarting any failed jobs. |
e3d08e6
to
652d1de
Compare
FWIW, the Fedora/RHEL package builds fine with the current version of this PR. |
[release-0.4, RFC] backports for 0.4.2
cc @ViralBShah
still working on this, putting up my progress so farmore or less ready I think, running PkgEval now