Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lineno fixes #13491

Merged
merged 2 commits into from
Oct 8, 2015
Merged

lineno fixes #13491

merged 2 commits into from
Oct 8, 2015

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 7, 2015

fixes #922 (wrong line numbers in error expressions)

carnaval
carnaval reviewed Oct 8, 2015
View reviewed changes
src/task.c
{
jl_throw(e);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-(

@ihnorton
Copy link
Member

ihnorton commented Oct 8, 2015

👍 LGTM

@Keno
Copy link
Member

Keno commented Oct 8, 2015

Are we sure that disabling tail merging globally is a good idea? What are the performance impacts on other code that benefits from this optimization?

@vtjnash
Copy link
Member Author

vtjnash commented Oct 8, 2015

Are we sure that disabling tail merging globally is a good idea? What are the performance impacts on other code that benefits from this optimization?

it should result in a very small performance increase (yes, benefit) on some paths in functions that this affects, at the cost of not detecting when the user has duplicated code on multiple function branches (e.g. due to inlining and macros) and folding away the line numbers for that (thus losing on the code-size benefit of this optimization).

we might want to manually merge all of the gc-frame pops into a single BasicBlock to cut down on the number of prologues that get emitted. (e.g. this pass, but with more specificity for Julia)

vtjnash added a commit that referenced this pull request Oct 8, 2015
@vtjnash
Merge pull request #13491 from JuliaLang/jn/lineno_fixes
646ea37 
fix tail line numbers in backtraces
@vtjnash vtjnash merged commit 646ea37 into master Oct 8, 2015
@vtjnash vtjnash deleted the jn/lineno_fixes branch October 8, 2015 15:35
@vtjnash
Copy link
Member Author

vtjnash commented Oct 9, 2015

also include a70d7cf when backporting

@kshyatt kshyatt mentioned this pull request Oct 13, 2015
Closed
14 tasks
@tkelman tkelman mentioned this pull request Oct 13, 2015
Merged
@ihnorton ihnorton mentioned this pull request Oct 17, 2015
Closed
This was referenced Oct 23, 2015
Merged
Closed
@JeffBezanson JeffBezanson mentioned this pull request Oct 29, 2015
Closed
This was referenced Oct 31, 2015
Merged
Closed
@vtjnash vtjnash mentioned this pull request Nov 3, 2015
Closed
vtjnash added a commit that referenced this pull request Nov 29, 2015
@vtjnash @tkelman
preserve inline line numbers during inlining
488fb5a 
(cherry picked from commit a33cd07)
ref #13491
@tkelman tkelman mentioned this pull request Nov 29, 2015
Merged
@tkelman
Copy link
Contributor

tkelman commented Dec 2, 2015

removing the backport label given #14186

@tkelman tkelman mentioned this pull request Mar 7, 2016
Merged
8 tasks
tkelman pushed a commit that referenced this pull request Mar 13, 2016
@vtjnash @tkelman
fix #922 (wrong line numbers in error expressions) and remove old hac…
84c1be4 
…ks around this issue

(cherry picked from commit af81d6c)
ref #13491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect line number reported for index out of range error
6 participants
@vtjnash @ihnorton @Keno @tkelman @andreasnoack @carnaval