[release-0.4] WIP: backports for 0.4.4 #15385

tkelman · 2016-03-07T13:29:57Z

If you'd like to nominate anything that doesn't already have the label go ahead and leave a comment here - especially doc-only or test-only changes are usually fair game.

TODO's:

Move discussion about abstract types in fields from FAQ to performances #12429 plus fixes to satisfy sphinx
Remove method that produces error for prod(AbstractArray{Bool}). #14659 borderline, behavior change
Safer serialization of ::SubArray{T,N,A<:Array} #14625 also a bit of a behavior change
ARM ABI #14194 needs to be done carefully to work on old llvm / pre-codegen-rewrite
Fix appveyor segfault from toolchain ABI incompatibilities #15285 need to test whether this works properly with winrpm on release-0.4 (edit: it didn't, see 36089d7 for temporary workaround)
Fix some promotions in CHOLMOD and throw MethodError for BigFloat. #14902 need help with resolving conflicts
BoundsError line numbers in 0.4 #13818 and UndefVarError line number wrong [0.4 only] #13851, possibly could be fixed by backporting the non-breaking part of lineno fixes #13491 but needs to be done carefully
pkgeval

When a code block included a ```, it would not be rendered correctly. (cherry picked from commit 60eda14) ref #14638

(cherry picked from commit ce9d225) ref #14644

(cherry picked from commit c1005bf) ref #14301

(cherry picked from commit f95ffcd)

this was causing several package test failures on jb/functions (cherry picked from commit ec3d632) ref #14673

(cherry picked from commit a49bef9) ref #14680

…exception (cherry picked from commit 9723d52) ref #14661

All the memory accesses are contiguous, so there's no point in copying data around. (cherry picked from commit 1d10910) ref #14703

(cherry picked from commit bcc6e2f) ref #14630

fixes #14467 performance regression (and some) (cherry picked from commit 9dbc3ab) ref #14667

(cherry picked from commit d0fbd71) ref #14519

(cherry picked from commit 9d14d39)

(cherry picked from commit 50be996) ref #14688

Fixes #13200 (cherry picked from commit 59ca442) ref #14773

to a CHOLMOD.Dense (cherry picked from commit 2b6c143) ref #14812 Use SparseMatrix instead of SparseArrays for release-0.4

a new type's supertype was not taken into account while instantiating the types of its fields (cherry picked from commit 0dd74d5) ref #14847

…elease-0.4

(cherry picked from commit a0b5414)

…4 system blas and link cholmod to lapack, needs dpotrf (cherry picked from commit 4ec8918)

this should only matter in the rare case where you're building reference lapack from source against an ILP64 blas (cherry picked from commit 06c9fb7)

(cherry picked from commit 9cda53d) ref #14830

(cherry picked from commit 41911d9) ref #12146

[ci skip] (cherry picked from commit abdfc24)

(cherry picked from commit 3051685) ref #14899

Fix the error message and make the dimension output format consistent with how `size(mtx)` does it. (cherry picked from commit f197e8c) ref #14907

(cherry picked from commit ec13d73) ref #14906

(cherry picked from commit e9a16e9) ref #14906

(cherry picked from commit 34d1d30) ref #15288

(cherry picked from commit 786e5b4) ref #15306

(cherry picked from commit 27faae4) ref #15318

fix error reporting conditions for BLAS.axpy!, BLAS.copy!, diag and getindex of Tridiagonal and SymTridiagonal, and umfpack (cherry picked from commit 4e207ac) ref #14824

(cherry picked from commit cbd47f2)

nalimilan · 2016-03-07T20:45:21Z

RPM builds went fine, so +1

(cherry picked from commit 02660d2) ref #12429

grammar fix in doc/manual/modules.rst (cherry picked from commit f06868d)

Use versions from the build system rather than win-extras (which downloads from opensuse) Remove gcc dlls from downloaded nightly on appveyor (cherry picked from commit c1e565c) ref #15285

from juliacache to fix ABI incompatibilities and get a release out mostly reverts e4bd799

…ks around this issue (cherry picked from commit af81d6c) ref #13491

(cherry picked from commit 249c91a) ref #13698

musm · 2016-03-13T17:55:05Z

can include #15407

(cherry picked from commit ae775ea) ref #15407

[av skip]

toivoh · 2016-03-13T20:59:33Z

#15309? I saw you added the back port pending label to it.

tkelman · 2016-03-13T21:03:59Z

@toivoh I guess I can put that in, it'll require re-running PkgEval. My previous run at 1d27400 is showing regressions in DictFiles, ExperimentalAnalysis, and FunctionalData, so will need some more tweaking and a re-run of PkgEval. Logs at https://gist.github.com/bbaaf1b809a2b50d0d56

I bisected the FunctionalData failure to 132cb20, @yuyichao can you take a look?

tkelman · 2016-03-13T21:55:07Z

DictFiles failure starts happening at the same commit. ExperimentalAnalysis was a PyCall segfault that I'm having trouble reproducing.

yuyichao · 2016-03-13T22:46:53Z

The issue with FunctionalData is that the local function pass is now refering to a global function vect that specialized on (and therefore has a reference to) a type (_somedummytype) that is not defined on the worker process. I'm not really familiar with the serialization of functions/types (and when is @everywhere necessary) to tell what's the right fix....

Given this commit is causing too much trouble and is fixing unlikely segfault for a unsupported usage (#265) I think we can leave this out for backporting.....

This reverts commit fa6802d.

This reverts commit 132cb20.

They are still given to the user in macro arguments, otherwise LineNumberNode seems to be used consistently. (cherry picked from commit 3a16b19) ref #15309

toivoh · 2016-03-14T05:35:19Z

@tkelman: Yeah, or if it's too much trouble then you can just wait with it.

and fix some broken links

tkelman · 2016-03-15T10:19:27Z

A handful of failures here that all seem intermittent, I can't reproduce any of them locally. https://gist.github.com/0c394be0a2f0b4e0d736

I'll merge and tag this soon, assuming my incoming trivial doc fix passes.

[release-0.4] WIP: backports for 0.4.4

hayd and others added 30 commits March 7, 2016 04:38

Fix rendering bug of Markdown Code.

397a781

When a code block included a ```, it would not be rendered correctly. (cherry picked from commit 60eda14) ref #14638

Document how to make a kwarg's type explicit.

d8e2537

(cherry picked from commit ce9d225) ref #14644

Root the function object in jlcall

132cb20

(cherry picked from commit c1005bf) ref #14301

Add test for missing linfo root for jlcall function object

fa6802d

(cherry picked from commit f95ffcd)

fix incremental deserializer on some cases of external singleton values

235fde2

this was causing several package test failures on jb/functions (cherry picked from commit ec3d632) ref #14673

Fix spelling errors

a437ee9

(cherry picked from commit a49bef9) ref #14680

formatting fixup on test/repl.jl, best viewed with ?w=1

9e625f6

return false from hascolor if success(tput setaf 0) throws a julia …

884d2d0

…exception (cherry picked from commit 9723d52) ref #14661

Use naïve algorithm for generic A[tc]_mul_B!

221e865

All the memory accesses are contiguous, so there's no point in copying data around. (cherry picked from commit 1d10910) ref #14703

fix a typo

2ff37c9

(cherry picked from commit bcc6e2f) ref #14630

add fast-path optimizations for reading LibuvStreams

131a2df

fixes #14467 performance regression (and some) (cherry picked from commit 9dbc3ab) ref #14667

Remove readbytes! method introduced in #14667 that broke MbedTLS.jl

148dd77

Implement AArch64 ABI

d776ca8

(cherry picked from commit d0fbd71) ref #14519

Updated out-of-date comment in AArch64 ABI file.

3602b5b

(cherry picked from commit 9d14d39)

Reorganize abi_aarch64.cpp and fix HVA and HFA support

6632662

(cherry picked from commit 50be996) ref #14688

Document requirement of __precompile__

f5a38dc

Fixes #13200 (cherry picked from commit 59ca442) ref #14773

Undo a doc update that is not accurate for release-0.4

d21e9b0

Fix promotion of element types when converting a Vector or Matrix

1a706c4

to a CHOLMOD.Dense (cherry picked from commit 2b6c143) ref #14812 Use SparseMatrix instead of SparseArrays for release-0.4

fix #14825

d214e1c

a new type's supertype was not taken into account while instantiating the types of its fields (cherry picked from commit 0dd74d5) ref #14847

Add extern declaration of jl_symbol_name which is not in julia.h on r…

fd33166

…elease-0.4

fix eof definitions and add tests

119c9bf

(cherry picked from commit a0b5414)

Use -fdefault-integer-8 when building lapack from source against ILP6…

9f70f69

…4 system blas and link cholmod to lapack, needs dpotrf (cherry picked from commit 4ec8918)

intel fortran compiler uses a different flag for integer size

d7dd764

this should only matter in the rare case where you're building reference lapack from source against an ILP64 blas (cherry picked from commit 06c9fb7)

Add ScalarEvolutionExpander patch.

910baf8

(cherry picked from commit 9cda53d) ref #14830

Big overhaul of "Scope" manual section

64da48a

(cherry picked from commit 41911d9) ref #12146

Some updates after a mailing-list conversation

a06f8a5

[ci skip] (cherry picked from commit abdfc24)

Fixed whitespace and two typos

83e6732

(cherry picked from commit 3051685) ref #14899

fix typo in _generic_matmatmul!()

b5cd49c

Fix the error message and make the dimension output format consistent with how `size(mtx)` does it. (cherry picked from commit f197e8c) ref #14907

ccalltest: fix format string for Julia integers.

1a020b0

(cherry picked from commit ec13d73) ref #14906

Try to fix win32 ABI

2940a3d

(cherry picked from commit e9a16e9) ref #14906

timholy and others added 5 commits March 7, 2016 09:04

Check stride on preallocated output for matmul (fixes #15286)

c747915

(cherry picked from commit 34d1d30) ref #15288

Fix check of inner dimension in matmul for 2x2 and 3x3 outer dimension

c53b24f

(cherry picked from commit 786e5b4) ref #15306

Fix missing GC root in table.c

1d27400

(cherry picked from commit 27faae4) ref #15318

BoundsError does not take a string

ca4f7f3

fix error reporting conditions for BLAS.axpy!, BLAS.copy!, diag and getindex of Tridiagonal and SymTridiagonal, and umfpack (cherry picked from commit 4e207ac) ref #14824

Add a test that should have been part of #5492

bc5ea27

(cherry picked from commit cbd47f2)

matthieugomez and others added 6 commits March 8, 2016 18:43

Move discussion about abstract types in fields from FAQ to performances

05b1aed

(cherry picked from commit 02660d2) ref #12429

Fix various sphinx warnings about misformatted rst

93e38d8

grammar fix in doc/manual/modules.rst (cherry picked from commit f06868d)

Do not copy gcc dlls from dist-extras in windows binary-dist

e4bd799

Use versions from the build system rather than win-extras (which downloads from opensuse) Remove gcc dlls from downloaded nightly on appveyor (cherry picked from commit c1e565c) ref #15285

Temporary ugly hack to download old versions of winrpm gcc dll's

36089d7

from juliacache to fix ABI incompatibilities and get a release out mostly reverts e4bd799

fix #922 (wrong line numbers in error expressions) and remove old hac…

84c1be4

…ks around this issue (cherry picked from commit af81d6c) ref #13491

generalize backtrace test to succeed without inlining

e5701a5

(cherry picked from commit 249c91a) ref #13698

mustafa and others added 2 commits March 13, 2016 10:57

Fix axpy! bug and add tests

a5ba47a

(cherry picked from commit ae775ea) ref #15407

Confirm overwrite with 7z

647cb78

[av skip]

tkelman and others added 3 commits March 13, 2016 16:46

Revert "Add test for missing linfo root for jlcall function object"

7d85e10

This reverts commit fa6802d.

Revert "Root the function object in jlcall"

6fffa59

This reverts commit 132cb20.

Reinstate printing of :line Exprs

d4d0156

They are still given to the user in macro arguments, otherwise LineNumberNode seems to be used consistently. (cherry picked from commit 3a16b19) ref #15309

Fix line numbers in doctests

fe33ecc

and fix some broken links

tkelman added a commit that referenced this pull request Mar 15, 2016

Merge pull request #15385 from JuliaLang/tk/backports-0.4.4

793526a

[release-0.4] WIP: backports for 0.4.4

tkelman merged commit 793526a into release-0.4 Mar 15, 2016

tkelman deleted the tk/backports-0.4.4 branch March 15, 2016 12:17

This was referenced Mar 15, 2016

BoundsError line numbers in 0.4 #13818

Closed

UndefVarError line number wrong [0.4 only] #13851

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-0.4] WIP: backports for 0.4.4 #15385

[release-0.4] WIP: backports for 0.4.4 #15385

tkelman commented Mar 7, 2016

nalimilan commented Mar 7, 2016

musm commented Mar 13, 2016

toivoh commented Mar 13, 2016

tkelman commented Mar 13, 2016

tkelman commented Mar 13, 2016

yuyichao commented Mar 13, 2016

toivoh commented Mar 14, 2016

tkelman commented Mar 15, 2016

[release-0.4] WIP: backports for 0.4.4 #15385

[release-0.4] WIP: backports for 0.4.4 #15385

Conversation

tkelman commented Mar 7, 2016

nalimilan commented Mar 7, 2016

musm commented Mar 13, 2016

toivoh commented Mar 13, 2016

tkelman commented Mar 13, 2016

tkelman commented Mar 13, 2016

yuyichao commented Mar 13, 2016

toivoh commented Mar 14, 2016

tkelman commented Mar 15, 2016