Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix socket test on read-only file system #13934

Merged
merged 1 commit into from
Nov 10, 2015
Merged

Fix socket test on read-only file system #13934

merged 1 commit into from
Nov 10, 2015

Conversation

petercolberg
Copy link
Contributor

The socket test hangs if the directory containing the tests is not writable to the user running the tests:

julia> Base.runtests("socket")
     * socket               ERROR (unhandled task failure): bind: read-only file system (EROFS)
 in bind at stream.jl:1083
 in listen at stream.jl:1095
 [inlined code] from /usr/share/julia/test/socket.jl:95
 in anonymous at task.jl:447

This commit creates the socket in a temporary directory that is removed upon exiting the scope.

@petercolberg
Fix socket test on read-only file system
7149d1a 
The socket test hangs if the directory containing the tests is
not writable to the user running the tests. Create socket in a
temporary directory that is removed upon exiting the scope.
@tkelman tkelman added the test This change adds or pertains to unit tests label Nov 10, 2015
@petercolberg
Copy link
Contributor Author

This patch also applies to the julia-0.4 branch.

vtjnash added a commit that referenced this pull request Nov 10, 2015
@vtjnash
Merge pull request #13934 from petercolberg/master
72db726 
Fix socket test on read-only file system
@vtjnash vtjnash merged commit 72db726 into JuliaLang:master Nov 10, 2015
tkelman pushed a commit that referenced this pull request Nov 29, 2015
@petercolberg @tkelman
Fix socket test on read-only file system
08d9c7f 
The socket test hangs if the directory containing the tests is
not writable to the user running the tests. Create socket in a
temporary directory that is removed upon exiting the scope.

(cherry picked from commit 7149d1a)
ref #13934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petercolberg @vtjnash @tkelman