Skip to content

Commit

Permalink
[ML]Transforms and Anomaly detection: update width for icon in messag…
Browse files Browse the repository at this point in the history
…es tab to prevent overlap (elastic#188374)

## Summary

Fixes elastic#188362
Updates the icon column width to prevent overlap between the icon and
timestamp text. Also updates the transform table messages tab to use the
info icons for info level messages to be consistent with messages in the
anomalies table job messages.

This PR also updates the anomaly detection jobs list messages tab where
the same issue was occurring.

This PR is a temporary fix for a EUI regression and will be reverted
once the fix (elastic/eui#7888) is in


Before:

<img width="1451" alt="image"
src="https://github.com/user-attachments/assets/b5d89ac8-573a-45d4-8888-a3a2c48e5fd4">

After:

<img width="1211" alt="image"
src="https://github.com/user-attachments/assets/da8e99c0-704f-4b53-b152-67b72aa655c3">

Anomalies table fix:

<img width="1344" alt="image"
src="https://github.com/user-attachments/assets/4bf99825-9be9-4b89-842b-e9d1610b5294">




### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Walter Rafelsberger <[email protected]>
  • Loading branch information
4 people authored Jul 19, 2024
1 parent c830fbb commit caa5686
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { EuiSpacer, EuiInMemoryTable, EuiButtonIcon, EuiToolTip } from '@elastic

import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n-react';
import { euiLightVars as theme } from '@kbn/ui-theme';
import { timeFormatter } from '@kbn/ml-date-utils';

import type { JobMessage } from '../../../../common/types/audit_message';
Expand Down Expand Up @@ -66,7 +65,7 @@ export const JobMessages: FC<JobMessagesProps> = ({
''
),
render: (message: JobMessage) => <JobIcon message={message} />,
width: `${theme.euiSizeL}`,
width: '6%',
},
{
field: 'timestamp',
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/transform/public/app/components/job_icon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ export const JobIcon: FC<Props> = ({ message, showTooltip = false }) => {
}

let color = 'primary';
const icon = 'warning';
let icon = 'warning';

if (message.level === INFO) {
color = 'primary';
icon = 'iInCircle';
} else if (message.level === WARNING) {
color = 'warning';
} else if (message.level === ERROR) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import React, { type FC } from 'react';
import { css } from '@emotion/react';

import { EuiTabbedContent } from '@elastic/eui';
import { useEuiTheme, EuiTabbedContent } from '@elastic/eui';

import { i18n } from '@kbn/i18n';
import { stringHash } from '@kbn/ml-string-hash';
Expand All @@ -30,6 +30,7 @@ interface Props {
}

export const ExpandedRow: FC<Props> = ({ item, onAlertEdit }) => {
const { euiTheme } = useEuiTheme();
const tabId = stringHash(item.id);

const tabs = [
Expand Down Expand Up @@ -112,7 +113,8 @@ export const ExpandedRow: FC<Props> = ({ item, onAlertEdit }) => {
onTabClick={() => {}}
expand={false}
css={css`
width: 100%;
margin-left: -${euiTheme.size.xl};
width: calce(100% + ${euiTheme.size.xl});
.euiTable {
background-color: transparent;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@
import type { MouseEvent } from 'react';
import React, { useState, type FC } from 'react';

import type { EuiBasicTableProps } from '@elastic/eui';
import { useEuiTheme, type EuiBasicTableProps } from '@elastic/eui';
import { formatDate, EuiPanel, EuiBasicTable, EuiToolTip, EuiButtonIcon } from '@elastic/eui';

import { euiLightVars as theme } from '@kbn/ui-theme';
import { i18n } from '@kbn/i18n';

import { useEnabledFeatures } from '../../../../serverless_context';
Expand All @@ -31,6 +30,7 @@ interface Sorting {
}

export const ExpandedRowMessagesPane: FC<ExpandedRowMessagesPaneProps> = ({ transformId }) => {
const { euiTheme } = useEuiTheme();
const { showNodeInfo } = useEnabledFeatures();

const [pageIndex, setPageIndex] = useState(0);
Expand Down Expand Up @@ -80,8 +80,12 @@ export const ExpandedRowMessagesPane: FC<ExpandedRowMessagesPaneProps> = ({ tran
) : (
''
),
render: (message: TransformMessage) => <JobIcon message={message} />,
width: theme.euiSizeXL,
render: (message: TransformMessage) => (
<div css={{ marginLeft: `-${euiTheme.base * 1.75}px` }}>
<JobIcon message={message} />
</div>
),
width: euiTheme.size.xl,
},
{
field: 'timestamp',
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/transform/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
"@kbn/es-query",
"@kbn/ml-agg-utils",
"@kbn/ml-string-hash",
"@kbn/ui-theme",
"@kbn/field-types",
"@kbn/ml-nested-property",
"@kbn/ml-is-defined",
Expand Down

0 comments on commit caa5686

Please sign in to comment.