[ML]Transforms and Anomaly detection: updates width for icon in messages tab to prevent overlap #188374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-ui (:ml) |
alvarezmelissa87
requested review from
walterra,
qn895 and
peteharverson
and removed request for
qn895
There was a problem hiding this comment.
Layout now looks good.
I noticed that we use a different icon for info level messages compared to anomaly detection and DFA job messages. What do you think about using iInCircle in transforms as we do for jobs - adding in the extra check as we use in https://github.com/elastic/kibana/blob/main/x-pack/plugins/ml/public/application/components/job_message_icon/job_message_icon.tsx#L29.
Transforms:
Jobs:
|
Unfortunately it looks like this doesn't get rid of the root of the problem. I'm still seeing overlaps on narrow screen widths like here: 
Since this is about a fixed width icon, we should avoid using a percentage based column width. Looking at the DOM/CSS, this might actually be an EUI bug/regression with nested tables: The main transform list table has checkboxes in the first column. The inner messages table adds a 
Might be worth asking the EUI team for input on this. |
|
It is also happening in the anomaly detection jobs list messages tab. I can't reproduce for the DFA table. |
|
To update, this is an EUI issue - it's being tracked here and should be fixed within a couple of weeks. The changes here can be reverted once that goes in. Since the change to the width will be reverted in a week or two once the EUI fix goes in, I think it's okay to keep as a percentage for the anomalies table since there is no overlap issue there - I incorporated your changes into the transforms one, though @walterra. In the follow up reverting this change - I have also been advised by the EUI team to move away from cc @walterra, @peteharverson for your thoughts |
|
@elasticmachine merge upstream |
…terra CSS fixes to keep fixed widths instead of percentages
peteharverson
approved these changes
Jul 19, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
alvarezmelissa87
changed the title
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 19, 2024
…es tab to prevent overlap (elastic#188374) ## Summary Fixes elastic#188362 Updates the icon column width to prevent overlap between the icon and timestamp text. Also updates the transform table messages tab to use the info icons for info level messages to be consistent with messages in the anomalies table job messages. This PR also updates the anomaly detection jobs list messages tab where the same issue was occurring. This PR is a temporary fix for a EUI regression and will be reverted once the fix (elastic/eui#7888) is in Before: <img width="1451" alt="image" src="https://github.com/user-attachments/assets/b5d89ac8-573a-45d4-8888-a3a2c48e5fd4"> After: <img width="1211" alt="image" src="https://github.com/user-attachments/assets/da8e99c0-704f-4b53-b152-67b72aa655c3"> Anomalies table fix: <img width="1344" alt="image" src="https://github.com/user-attachments/assets/4bf99825-9be9-4b89-842b-e9d1610b5294"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Walter Rafelsberger <[email protected]> (cherry picked from commit caa5686)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
alvarezmelissa87
added a commit
that referenced
this pull request
Jul 19, 2024
… messages tab to prevent overlap (#188374) (#188777) # Backport This will backport the following commits from `main` to `8.15`: - [[ML]Transforms and Anomaly detection: update width for icon in messages tab to prevent overlap (#188374)](#188374) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Melissa Alvarez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-19T17:39:43Z","message":"[ML]Transforms and Anomaly detection: update width for icon in messages tab to prevent overlap (#188374)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/188362\r\nUpdates the icon column width to prevent overlap between the icon and\r\ntimestamp text. Also updates the transform table messages tab to use the\r\ninfo icons for info level messages to be consistent with messages in the\r\nanomalies table job messages.\r\n\r\nThis PR also updates the anomaly detection jobs list messages tab where\r\nthe same issue was occurring.\r\n\r\nThis PR is a temporary fix for a EUI regression and will be reverted\r\nonce the fix (elastic/eui#7888) is in\r\n\r\n\r\nBefore:\r\n\r\n<img width=\"1451\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/b5d89ac8-573a-45d4-8888-a3a2c48e5fd4\">\r\n\r\nAfter:\r\n\r\n<img width=\"1211\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/da8e99c0-704f-4b53-b152-67b72aa655c3\">\r\n\r\nAnomalies table fix:\r\n\r\n<img width=\"1344\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/4bf99825-9be9-4b89-842b-e9d1610b5294\">\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Walter Rafelsberger <[email protected]>","sha":"caa56862de1905a7e62cb2fffb92ced06fd8dc23","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Transforms","v8.15.0","v8.16.0"],"title":"[ML]Transforms and Anomaly detection: update width for icon in messages tab to prevent overlap","number":188374,"url":"https://github.com/elastic/kibana/pull/188374","mergeCommit":{"message":"[ML]Transforms and Anomaly detection: update width for icon in messages tab to prevent overlap (#188374)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/188362\r\nUpdates the icon column width to prevent overlap between the icon and\r\ntimestamp text. Also updates the transform table messages tab to use the\r\ninfo icons for info level messages to be consistent with messages in the\r\nanomalies table job messages.\r\n\r\nThis PR also updates the anomaly detection jobs list messages tab where\r\nthe same issue was occurring.\r\n\r\nThis PR is a temporary fix for a EUI regression and will be reverted\r\nonce the fix (elastic/eui#7888) is in\r\n\r\n\r\nBefore:\r\n\r\n<img width=\"1451\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/b5d89ac8-573a-45d4-8888-a3a2c48e5fd4\">\r\n\r\nAfter:\r\n\r\n<img width=\"1211\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/da8e99c0-704f-4b53-b152-67b72aa655c3\">\r\n\r\nAnomalies table fix:\r\n\r\n<img width=\"1344\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/4bf99825-9be9-4b89-842b-e9d1610b5294\">\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Walter Rafelsberger <[email protected]>","sha":"caa56862de1905a7e62cb2fffb92ced06fd8dc23"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188374","number":188374,"mergeCommit":{"message":"[ML]Transforms and Anomaly detection: update width for icon in messages tab to prevent overlap (#188374)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/188362\r\nUpdates the icon column width to prevent overlap between the icon and\r\ntimestamp text. Also updates the transform table messages tab to use the\r\ninfo icons for info level messages to be consistent with messages in the\r\nanomalies table job messages.\r\n\r\nThis PR also updates the anomaly detection jobs list messages tab where\r\nthe same issue was occurring.\r\n\r\nThis PR is a temporary fix for a EUI regression and will be reverted\r\nonce the fix (elastic/eui#7888) is in\r\n\r\n\r\nBefore:\r\n\r\n<img width=\"1451\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/b5d89ac8-573a-45d4-8888-a3a2c48e5fd4\">\r\n\r\nAfter:\r\n\r\n<img width=\"1211\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/da8e99c0-704f-4b53-b152-67b72aa655c3\">\r\n\r\nAnomalies table fix:\r\n\r\n<img width=\"1344\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/4bf99825-9be9-4b89-842b-e9d1610b5294\">\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Walter Rafelsberger <[email protected]>","sha":"caa56862de1905a7e62cb2fffb92ced06fd8dc23"}}]}] BACKPORT--> Co-authored-by: Melissa Alvarez <[email protected]>
cee-chen
pushed a commit
that referenced
this pull request
Jul 25, 2024
`v95.3.0` ⏩ `v95.4.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.4.0`](https://github.com/elastic/eui/releases/v95.4.0) - Added `anomalyChart`, `anomalySwimLane`, `changePointDetection`, `fieldStatistics`, `logPatternAnalysis`, `logRateAnalysis` and `singleMetricViewer` glyph to `EuiIcon` ([#7873](elastic/eui#7873)) **Bug fixes** - Fixed overlapping content in `EuiBasicTable` for expanded and selectable table rows ([#7895](elastic/eui#7895)) - Fixed the alignment of `EuiBasicTable` mobile actions ([#7895](elastic/eui#7895)) **Accessibility** - Improved `EuiStat`'s screen reader accessibility ([#7864](elastic/eui#7864)) --- ## Additional Changes - reverts temporary fix for overlapping content in nested tables done in PR [#188374](#188374) --------- Co-authored-by: Elastic Machine <[email protected]>
szabosteve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #188362
Updates the icon column width to prevent overlap between the icon and timestamp text. Also updates the transform table messages tab to use the info icons for info level messages to be consistent with messages in the anomalies table job messages.
This PR also updates the anomaly detection jobs list messages tab where the same issue was occurring.
This PR is a temporary fix for a EUI regression and will be reverted once the fix (elastic/eui#7888) is in
Before:
After:
Anomalies table fix:
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers