Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typeahead] Set top position #7873

Merged
merged 1 commit into from
Jul 28, 2016
Merged

[typeahead] Set top position #7873

merged 1 commit into from
Jul 28, 2016

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Jul 27, 2016

Currently in Chrome 52+ the absolutely position typeahead box is (correctly?) going to the top left corner of its container and overlapping the search input. This explicitly sets it 32 pixels from the top.

Closes #7801

Unverified

This user has not yet uploaded their public signing key.
@LeeDr
Copy link

LeeDr commented Jul 28, 2016

LGTM on Chrome 51 on Windows
LGTM on Firefox 46.0.1 (47 is the latest now)
LGTM on IE 11
LGTM on Edge 25.10586.0.0

@maraino
Copy link

maraino commented Jul 28, 2016

LGTM on Chrome 52 Mac
LGTM on Safari 9.1.2 Mac

@w33ble
Copy link
Contributor

w33ble commented Jul 28, 2016

LGTM, Chrome 52 and Firefox 45 on Mac.

@jbudz jbudz merged commit a039064 into elastic:master Jul 28, 2016
elastic-jasper added a commit that referenced this pull request Jul 28, 2016
---------

**Commit 1:**
[typeahead] Set top position

* Original sha: dccc3be
* Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-07-27T23:07:00Z
elastic-jasper added a commit that referenced this pull request Jul 28, 2016
---------

**Commit 1:**
[typeahead] Set top position

* Original sha: dccc3be
* Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-07-27T23:07:00Z
jbudz added a commit to jbudz/kibana that referenced this pull request Jul 28, 2016
jbudz added a commit that referenced this pull request Jul 28, 2016
jbudz added a commit that referenced this pull request Jul 28, 2016
jbudz added a commit that referenced this pull request Jul 28, 2016
@epixa epixa added v5.0.0 and removed v5.0.0 labels Aug 1, 2016
@joshma
Copy link

joshma commented Aug 11, 2016

Hm, you might want to do top: 100% instead of top: 32px - that way it offsets by the parent container's height (equal to the input height) and stays that way even if the input height changes. Just thought I'd point it out, not too important obviously. :)

airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
[typeahead] Set top position

Former-commit-id: a039064
cee-chen pushed a commit that referenced this pull request Jul 25, 2024
`v95.3.0` ⏩ `v95.4.0`

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v95.4.0`](https://github.com/elastic/eui/releases/v95.4.0)

- Added `anomalyChart`, `anomalySwimLane`, `changePointDetection`,
`fieldStatistics`, `logPatternAnalysis`, `logRateAnalysis` and
`singleMetricViewer` glyph to `EuiIcon`
([#7873](elastic/eui#7873))

**Bug fixes**

- Fixed overlapping content in `EuiBasicTable` for expanded and
selectable table rows
([#7895](elastic/eui#7895))
- Fixed the alignment of `EuiBasicTable` mobile actions
([#7895](elastic/eui#7895))

**Accessibility**

- Improved `EuiStat`'s screen reader accessibility
([#7864](elastic/eui#7864))

---

## Additional Changes

- reverts temporary fix for overlapping content in nested tables done in
PR [#188374](#188374)

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants